Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added skeleton project for fdc desktop agent TS implementation #227

Merged
merged 2 commits into from
May 30, 2023

Conversation

ZKRobi
Copy link
Contributor

@ZKRobi ZKRobi commented May 30, 2023

Also some minor consistency changes

@ZKRobi ZKRobi requested a review from a team May 30, 2023 14:43
Copy link
Contributor

@kruplm kruplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZKRobi added 2 commits May 30, 2023 17:31
Changed test string in WebSocketEndToEntTests to match the usual naming form of ComposeUI
Changed messaging client build config and description to be consistent with other js projects in the repo
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #227 (76396c6) into main (b37b43b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   68.97%   68.97%           
=======================================
  Files         129      129           
  Lines        4499     4499           
  Branches      138      138           
=======================================
  Hits         3103     3103           
  Misses       1395     1395           
  Partials        1        1           

see 2 files with indirect coverage changes

@ZKRobi ZKRobi merged commit 616ae26 into morganstanley:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants