Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DesktopAgent backend implementation #233

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

ZKRobi
Copy link
Contributor

@ZKRobi ZKRobi commented Jun 6, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #233 (adb51e9) into main (a5afc1d) will decrease coverage by 0.09%.
The diff coverage is 76.56%.

❗ Current head adb51e9 differs from pull request most recent head f3c79e6. Consider uploading reports for the commit f3c79e6 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
- Coverage   72.94%   72.86%   -0.09%     
==========================================
  Files         139      147       +8     
  Lines        4628     4887     +259     
  Branches      139      139              
==========================================
+ Hits         3376     3561     +185     
- Misses       1251     1325      +74     
  Partials        1        1              
Impacted Files Coverage Δ
src/shell/dotnet/Shell/App.xaml.cs 0.00% <0.00%> (ø)
.../DesktopAgent/src/DesktopAgent/Fdc3DesktopAgent.cs 51.72% <51.72%> (ø)
.../src/DesktopAgent/Contracts/FindChannelResponse.cs 75.00% <75.00%> (ø)
...otnet/DesktopAgent/src/DesktopAgent/UserChannel.cs 84.05% <84.05%> (ø)
.../dotnet/DesktopAgent/src/DesktopAgent/Fdc3Topic.cs 90.90% <90.90%> (ø)
...t/src/DesktopAgent/Contracts/FindChannelRequest.cs 100.00% <100.00%> (ø)
...DesktopAgent/Contracts/GetCurrentContextRequest.cs 100.00% <100.00%> (ø)
...gent/DependencyInjection/Fdc3DesktopAgentConfig.cs 100.00% <100.00%> (ø)
...DependencyInjection/ServiceCollectionExtensions.cs 100.00% <100.00%> (ø)

... and 12 files with indirect coverage changes

@ZKRobi ZKRobi force-pushed the desktop-agent-backend branch 2 times, most recently from d9f256a to d2085bc Compare June 21, 2023 08:19
@ZKRobi ZKRobi marked this pull request as ready for review June 21, 2023 08:22
@ZKRobi ZKRobi requested a review from a team June 21, 2023 08:22
@ZKRobi ZKRobi force-pushed the desktop-agent-backend branch 2 times, most recently from dc36e58 to 24439f4 Compare June 21, 2023 13:05
@ZKRobi ZKRobi force-pushed the desktop-agent-backend branch 3 times, most recently from d81e177 to df58e0c Compare June 23, 2023 15:13
ZKRobi added 2 commits June 27, 2023 13:47
Implemented basic fdc3 object supporting UserChannels
Implemented broadcast and getCurrentContext on the fdc3 backend
Added fdc3 object to ServiceCollection
Create the "default" UserChannel on startup
@ZKRobi ZKRobi force-pushed the desktop-agent-backend branch from df58e0c to f3c79e6 Compare June 27, 2023 11:47
@ZKRobi ZKRobi merged commit 2b07558 into morganstanley:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants