Initial Fdc3 implemetation using MessageRouter, added unit tests #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #236 +/- ##
==========================================
+ Coverage 73.05% 74.92% +1.86%
==========================================
Files 147 155 +8
Lines 4892 5507 +615
Branches 139 233 +94
==========================================
+ Hits 3574 4126 +552
- Misses 1317 1380 +63
Partials 1 1
|
ztanczos
reviewed
Jun 14, 2023
kruplm
requested changes
Jun 16, 2023
lilla28
force-pushed
the
fdc3/implement-methods
branch
5 times, most recently
from
6e83bcf to
0e65c27
Compare
src/shell/js/composeui-fdc3/src/infrastructure/messages/Fdc3ErrorResponse.ts
Outdated
Show resolved
Hide resolved
src/shell/js/composeui-fdc3/src/infrastructure/messages/Fdc3GetCurrentContextRequest.ts
Outdated
Show resolved
Hide resolved
src/shell/js/composeui-fdc3/src/infrastructure/messages/Fdc3ContextMessage.ts
Outdated
Show resolved
Hide resolved
…renamed ComposeUIChannelType to ChannelType, and Fc3ChannelMessageRouterMEssage to Fdc3ChannelMessage, fixed topic/channelId confusion, fixed throw tests, added publish checks with arguments, simplified messageRouter mock, toEqual to tomMatchObject, STILL IN WIP: NEEDS to resolve module import for testing
…s, added FDC3 Error messages to DesktopAgent implementation, fixed throw tests, WIP: Still checking the error messages.
…l checks, moved under infrastructure folder, added more tests
… modification, using standard when addContextListener is called through ComposeUIListener, added some error handling, added new argument to ComposeUIListener as id, string interpolation fixes. WIP: NEEDS REBASE and get clientId from messageRouter to check if the channel can be created
… add invoke method to joinUserChannel to check if the channel could be created, fix tests, comment out not useable code, add more topics for later usage, fix unsubscribe method, add Response/Request message types to send through messageRouter
…ecessary variables, remove unnecessary async
lilla28
force-pushed
the
fdc3/implement-methods
branch
from
2fad3f7 to
0154548
Compare
src/shell/js/composeui-fdc3/src/infrastructure/messages/Fdc3FindChannelResponse.ts
Outdated
Show resolved
Hide resolved
src/shell/js/composeui-fdc3/src/infrastructure/ComposeUIChannel.ts
Outdated
Show resolved
Hide resolved
kruplm
requested changes
Jun 28, 2023
src/shell/js/composeui-fdc3/src/infrastructure/ComposeUITopic.ts
Outdated
Show resolved
Hide resolved
src/shell/js/composeui-fdc3/src/infrastructure/ComposeUITopic.ts
Outdated
Show resolved
Hide resolved
…from ComposeUIChannel, modified ComposeUITopic's topic creation semantics
BalassaMarton
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.