Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageBuffer.Factory and JSON extensions #237

Merged
merged 2 commits into from
Jun 19, 2023

Conversation

BalassaMarton
Copy link
Contributor

Added Factory stub to MessageBuffer
Added missing checks to MessageBuffer methods

@BalassaMarton BalassaMarton requested a review from a team June 15, 2023 15:46
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Merging #237 (e36257a) into main (7ec6dfd) will increase coverage by 0.44%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
+ Coverage   75.44%   75.89%   +0.44%     
==========================================
  Files         135      135              
  Lines        4391     4398       +7     
  Branches      138      138              
==========================================
+ Hits         3313     3338      +25     
+ Misses       1077     1059      -18     
  Partials        1        1              
Impacted Files Coverage Δ
src/messaging/dotnet/src/Core/MessageBuffer.cs 78.26% <92.30%> (+22.44%) ⬆️
...ing/dotnet/src/Core/MessageBufferJsonExtensions.cs 100.00% <100.00%> (ø)
...ing/dotnet/src/Core/MessageRouterJsonExtensions.cs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Added missing checks to MessageBuffer methods
@BalassaMarton BalassaMarton force-pushed the messagebuffer-factory branch from c3e5502 to ce5599f Compare June 16, 2023 20:18
@BalassaMarton BalassaMarton merged commit d966c88 into morganstanley:main Jun 19, 2023
@BalassaMarton BalassaMarton deleted the messagebuffer-factory branch June 19, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants