Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messaging: Added IConnectionFactory for correctly implementing disposable pattern #239

Conversation

BalassaMarton
Copy link
Contributor

@BalassaMarton BalassaMarton commented Jun 20, 2023

Added IConnectionFactory for correctly implementing disposable pattern

@BalassaMarton BalassaMarton requested a review from a team June 20, 2023 10:13
ztanczos
ztanczos previously approved these changes Jun 20, 2023
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Merging #239 (fd222c3) into main (34ad3a0) will decrease coverage by 0.05%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   72.85%   72.81%   -0.05%     
==========================================
  Files         137      139       +2     
  Lines        4605     4620      +15     
  Branches      138      138              
==========================================
+ Hits         3355     3364       +9     
- Misses       1249     1255       +6     
  Partials        1        1              
Impacted Files Coverage Δ
...src/Server/Server/WebSocket/WebSocketConnection.cs 73.27% <0.00%> (-0.64%) ⬇️
...ent/Client/WebSocket/WebSocketConnectionFactory.cs 57.14% <57.14%> (ø)
...ng/dotnet/src/Client/Client/MessageRouterClient.cs 62.08% <100.00%> (ø)
...bSocket/MessageRouterBuilderWebSocketExtensions.cs 60.00% <100.00%> (ø)
...t/src/Core/Protocol/Json/MessageBufferConverter.cs 81.81% <100.00%> (+4.04%) ⬆️
...et/src/Host/Client/Internal/InProcessConnection.cs 100.00% <100.00%> (ø)
...Host/Client/Internal/InProcessConnectionFactory.cs 100.00% <100.00%> (ø)
...nternal/MessageRouterBuilderInProcessExtensions.cs 100.00% <100.00%> (ø)
...ng/dotnet/src/Server/Server/MessageRouterServer.cs 87.30% <100.00%> (ø)

... and 1 file with indirect coverage changes

@BalassaMarton BalassaMarton merged commit e0cd1df into morganstanley:main Jun 20, 2023
@BalassaMarton BalassaMarton deleted the messagerouter-connectionfactory branch June 20, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants