Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on RecyclableMemoryStream #242

Merged
merged 1 commit into from
Jun 23, 2023

Conversation

BalassaMarton
Copy link
Contributor

...and use ArrayPoolBufferWriter instead

@BalassaMarton BalassaMarton requested a review from a team June 22, 2023 12:49
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #242 (2aa800f) into main (833c7c4) will increase coverage by 0.10%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   72.83%   72.94%   +0.10%     
==========================================
  Files         139      139              
  Lines        4624     4628       +4     
  Branches      139      139              
==========================================
+ Hits         3368     3376       +8     
+ Misses       1255     1251       -4     
  Partials        1        1              
Impacted Files Coverage Δ
...ing/dotnet/src/Core/MessageBufferJsonExtensions.cs 100.00% <ø> (ø)
...src/Client/Client/WebSocket/WebSocketConnection.cs 55.83% <63.63%> (-0.69%) ⬇️
...src/Server/Server/WebSocket/WebSocketConnection.cs 73.04% <100.00%> (-0.24%) ⬇️

... and 1 file with indirect coverage changes

@BalassaMarton BalassaMarton merged commit a5afc1d into morganstanley:main Jun 23, 2023
@BalassaMarton BalassaMarton deleted the bufferwriters branch June 23, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants