Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preload Fdc3 2.0 ComposeUIDesktopAgent for Embedded Browser #243

Merged
merged 35 commits into from
Jul 5, 2023

Conversation

kruplm
Copy link
Contributor

@kruplm kruplm commented Jun 23, 2023

Changes in this PR

  1. an IIFE bundle is being generated from our FDC3 DesktopAgent implementation, and preloaded into the Embedded Browser
  2. The IIFE Bundle is an Embedded Resource.
  3. The exports for the ComposeUIDesktopAgent have been changed so that methods can be accessible as per the standard: e.g fdc3.broadcast()
    4. copy-iife-bundle.ps1: script for copying the bundle. Also used as a pre-build event for .NET
  4. Prebuild event was added to build the composeui-fdc3 package
  • As a result the CI builds the JavaScript components first, so they can be used by the shell
  1. InjectFDC3(): It's part of the Shell, but it should be integrated into the FDC3 backend in a separate integration PR.
  2. PreloadFdc3.cs: For now it only contains the resource name for the FDC3 IIFE bundle, but it can be extended and moved to the DesktopAgent.sln later. The Namespace could contain other preloads es well for the Message Router, etc
  3. Tested with the FDC3 workbench and also added it for the demo ribbon menu and for the launch settings

Out of Scope for this PR

  • Making FDC3 an optional feature
  • Revisiting solutions for handling the building of dependencies across languages (see point 4)
  • Integrating with FDC3 backend (see point 5 and 6)

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #243 (7f60a89) into main (ce187cf) will decrease coverage by 0.10%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
- Coverage   74.92%   74.83%   -0.10%     
==========================================
  Files         155      156       +1     
  Lines        5507     5503       -4     
  Branches      233      233              
==========================================
- Hits         4126     4118       -8     
- Misses       1380     1384       +4     
  Partials        1        1              
Impacted Files Coverage Δ
src/shell/dotnet/Shell/App.xaml.cs 0.00% <0.00%> (ø)
src/shell/dotnet/Shell/Fdc3/PreloadFdc3.cs 100.00% <100.00%> (ø)
src/shell/dotnet/Shell/Utilities/ResourceReader.cs 100.00% <100.00%> (ø)
...ell/js/composeui-fdc3/src/ComposeUIDesktopAgent.ts 82.95% <100.00%> (ø)

... and 1 file with indirect coverage changes

@kruplm kruplm force-pushed the fdc3-preload branch 3 times, most recently from 08e90c3 to 6b8c2e5 Compare June 28, 2023 09:52
@kruplm kruplm marked this pull request as ready for review June 29, 2023 10:13
@kruplm kruplm requested a review from a team June 29, 2023 10:13
@ZKRobi ZKRobi self-requested a review July 5, 2023 15:30
@kruplm kruplm merged commit 6871647 into morganstanley:main Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants