Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shell/js): Fixed fdc3 DesktopAgent integration #250

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

ZKRobi
Copy link
Contributor

@ZKRobi ZKRobi commented Jul 6, 2023

No description provided.

@ZKRobi ZKRobi requested a review from a team July 6, 2023 13:55
@ZKRobi ZKRobi marked this pull request as draft July 6, 2023 13:59
psmulovics
psmulovics previously approved these changes Jul 6, 2023
@psmulovics
Copy link
Member

This seems to have a failed test?

@ZKRobi ZKRobi force-pushed the main branch 2 times, most recently from 229b64b to b74e3f2 Compare July 7, 2023 09:49
@ZKRobi
Copy link
Contributor Author

ZKRobi commented Jul 7, 2023

It shouldn't now :)

@ZKRobi ZKRobi marked this pull request as ready for review July 7, 2023 09:55
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #250 (229b64b) into main (6871647) will decrease coverage by 0.07%.
The diff coverage is 91.89%.

❗ Current head 229b64b differs from pull request most recent head b74e3f2. Consider uploading reports for the commit b74e3f2 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
- Coverage   74.70%   74.64%   -0.07%     
==========================================
  Files         156      155       -1     
  Lines        5503     5478      -25     
  Branches      233      233              
==========================================
- Hits         4111     4089      -22     
+ Misses       1391     1388       -3     
  Partials        1        1              
Impacted Files Coverage Δ
...oseui-fdc3/src/infrastructure/ComposeUIListener.ts 92.20% <70.00%> (+1.18%) ⬆️
...ell/js/composeui-fdc3/src/ComposeUIDesktopAgent.ts 83.11% <100.00%> (+0.16%) ⬆️
...poseui-fdc3/src/infrastructure/ComposeUIChannel.ts 100.00% <100.00%> (ø)
...omposeui-fdc3/src/infrastructure/ComposeUITopic.ts 93.10% <100.00%> (ø)

... and 1 file with indirect coverage changes

kruplm
kruplm previously approved these changes Jul 7, 2023
@kruplm kruplm merged commit a6d8b7c into morganstanley:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants