Added msbuild target to embed and build composeui-fdc3 package to the Shell project, changed project's files to use filescoped namespace, little refactoring around naming variables #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The bundle is an EmbeddedResource, right? In that case I don't think it should be copied to the output directory as a file, that seems redundant. |
ztanczos
reviewed
Aug 22, 2023
BalassaMarton
suggested changes
Aug 22, 2023
lilla28
force-pushed
the
build/fdc3-target
branch
3 times, most recently
from
f043334 to
0ab99a1
Compare
lilla28
commented
Aug 22, 2023
BalassaMarton
suggested changes
Aug 22, 2023
Codecov Report
@@ Coverage Diff @@
## main #329 +/- ##
==========================================
+ Coverage 74.61% 74.75% +0.14%
==========================================
Files 155 155
Lines 5475 5474 -1
Branches 233 233
==========================================
+ Hits 4085 4092 +7
+ Misses 1389 1381 -8
Partials 1 1
|
lilla28
force-pushed
the
build/fdc3-target
branch
from
a2ca1bb to
39de432
Compare
… Shell project, changed project's files to use filescoped namespace, little refactoring around naming variables
lilla28
force-pushed
the
build/fdc3-target
branch
from
6a3f8fb to
929815a
Compare
BalassaMarton
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Added msbuild target(s) for building and embed fdc3 bundle.
Be aware now the bundle file saved into the Output path (bin/Debug(Release)/net6.0-windows)
---> if we want to include it inside the project directory, I can change it.
block scoped namespace to file scoped namespace using (to be more consistent around the Shell project)
Refactoring around the names of the variables (readonly, using var, private, public fields etc.)