Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDC3 AppDirectory implementation #356

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

BalassaMarton
Copy link
Contributor

@BalassaMarton BalassaMarton commented Sep 18, 2023

Initial AppDirectory implementation
Work in progress with the following outstanding items:

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #356 (38110a4) into main (846f612) will decrease coverage by 0.05%.
The diff coverage is 82.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
- Coverage   77.29%   77.24%   -0.05%     
==========================================
  Files         156      160       +4     
  Lines        5302     5396      +94     
  Branches      233      233              
==========================================
+ Hits         4098     4168      +70     
- Misses       1203     1227      +24     
  Partials        1        1              
Files Changed Coverage Δ
...jection/ServiceCollectionAppDirectoryExtensions.cs 0.00% <0.00%> (ø)
...tnet/AppDirectory/src/AppDirectory/AppDirectory.cs 85.18% <85.18%> (ø)
...pDirectory/src/AppDirectory/AppDirectoryOptions.cs 100.00% <100.00%> (ø)
...Directory/src/AppDirectory/AppNotFoundException.cs 100.00% <100.00%> (ø)
.../MorganStanley.ComposeUI.Testing/TaskExtensions.cs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@BalassaMarton BalassaMarton marked this pull request as ready for review September 20, 2023 13:21
@BalassaMarton BalassaMarton requested a review from a team September 20, 2023 13:21
@BalassaMarton BalassaMarton merged commit 7087a6d into morganstanley:main Sep 20, 2023
2 of 4 checks passed
@BalassaMarton BalassaMarton deleted the fdc3-appdirectory branch September 22, 2023 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants