Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppDirectory+Shell integration #360

Conversation

BalassaMarton
Copy link
Contributor

Adds the AppDirectory to the Shell
Refactored configuration of FDC3-related services

@BalassaMarton BalassaMarton requested a review from a team September 22, 2023 15:17
@BalassaMarton BalassaMarton force-pushed the fdc3-appdirectory-shell-integration branch from a9146e6 to 4bec5a8 Compare September 22, 2023 15:19
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #360 (7fd5d5f) into main (3efe2e8) will decrease coverage by 0.12%.
Report is 1 commits behind head on main.
The diff coverage is 10.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #360      +/-   ##
==========================================
- Coverage   77.53%   77.41%   -0.12%     
==========================================
  Files         160      161       +1     
  Lines        5431     5438       +7     
  Branches      233      233              
==========================================
- Hits         4211     4210       -1     
- Misses       1219     1227       +8     
  Partials        1        1              
Files Changed Coverage Δ
...DependencyInjection/ServiceCollectionExtensions.cs 100.00% <ø> (+50.00%) ⬆️
src/shell/dotnet/Shell/App.xaml.cs 0.00% <0.00%> (ø)
src/shell/dotnet/Shell/Fdc3/Fdc3Options.cs 0.00% <0.00%> (ø)
...pDirectory/src/AppDirectory/AppDirectoryOptions.cs 100.00% <100.00%> (ø)
...ent/DependencyInjection/Fdc3DesktopAgentBuilder.cs 100.00% <100.00%> (+22.22%) ⬆️
...ent/DependencyInjection/Fdc3DesktopAgentOptions.cs 100.00% <100.00%> (ø)
.../DesktopAgent/src/DesktopAgent/Fdc3DesktopAgent.cs 93.75% <100.00%> (ø)

lilla28
lilla28 previously approved these changes Sep 25, 2023
lilla28
lilla28 previously approved these changes Sep 25, 2023
@BalassaMarton BalassaMarton merged commit 190378a into morganstanley:main Sep 28, 2023
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants