Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Module Loader implementation #377

Merged
merged 11 commits into from
Oct 17, 2023

Conversation

ztanczos
Copy link
Contributor

  • Refactored & added Module Loader to src
  • Module Loader is available via DI by calling AddModuleLoader()
  • Added unit tests
  • Stopping modules is not implemented yet
  • NativeModuleRunner is not implemented yet

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #377 (0734eb4) into main (90f7f56) will increase coverage by 0.33%.
The diff coverage is 85.00%.

❗ Current head 0734eb4 differs from pull request most recent head 393d943. Consider uploading reports for the commit 393d943 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
+ Coverage   77.06%   77.40%   +0.33%     
==========================================
  Files         167      173       +6     
  Lines        5486     5564      +78     
  Branches      233      233              
==========================================
+ Hits         4228     4307      +79     
+ Misses       1257     1256       -1     
  Partials        1        1              
Files Coverage Δ
...poseUI.ModuleLoader.Abstractions/StartupContext.cs 92.85% <100.00%> (+0.54%) ⬆️
...DependencyInjection/ServiceCollectionExtensions.cs 100.00% <100.00%> (ø)
...anStanley.ComposeUI.ModuleLoader/ModuleInstance.cs 92.85% <92.85%> (ø)
....ComposeUI.ModuleLoader/Runners/WebModuleRunner.cs 83.33% <83.33%> (ø)
...mposeUI.ModuleLoader/Runners/NativeModuleRunner.cs 33.33% <33.33%> (ø)
...rganStanley.ComposeUI.ModuleLoader/ModuleLoader.cs 82.60% <82.60%> (ø)

... and 6 files with indirect coverage changes

- Changed Module Starting as per PR feedback
@ztanczos ztanczos marked this pull request as ready for review October 17, 2023 10:54
@ztanczos ztanczos requested a review from a team as a code owner October 17, 2023 10:54
@ztanczos ztanczos merged commit 82abdfb into morganstanley:main Oct 17, 2023
2 checks passed
@ztanczos ztanczos deleted the ModuleLoader_initial branch February 7, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants