-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Module Loader implementation #377
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add GetProperties() method to StartupContext to enumerate all properties - Set properties on IModuleInstance from StartupContext during Start
Added unit tests
- Added more unit tests
…r which was upgraded accidentally
…mposeUI into ModuleLoader_initial
…xt & added locking
Codecov Report
@@ Coverage Diff @@
## main #377 +/- ##
==========================================
+ Coverage 77.06% 77.40% +0.33%
==========================================
Files 167 173 +6
Lines 5486 5564 +78
Branches 233 233
==========================================
+ Hits 4228 4307 +79
+ Misses 1257 1256 -1
Partials 1 1
|
- Minor changes to ModuleLoader
src/module-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader/ModuleLoader.cs
Outdated
Show resolved
Hide resolved
src/module-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader.Abstractions/IModuleRunner.cs
Outdated
Show resolved
Hide resolved
- Changed Module Starting as per PR feedback
src/module-loader/dotnet/src/MorganStanley.ComposeUI.ModuleLoader/ModuleLoader.cs
Show resolved
Hide resolved
BalassaMarton
approved these changes
Oct 17, 2023
ZKRobi
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddModuleLoader()