Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Module Loader into the shell #382

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

BalassaMarton
Copy link
Contributor

  • Added the Module Loader to the Shell
  • Implemented a simple Module Catalog (supporting only web modules)
  • WebWindow now loads the preload scripts dynamically using script provider abstraction
  • Moved startup logic to startup actions
  • Revamped main window
  • Removed the example manifest and added a new one to a dedicated examples folder

@BalassaMarton BalassaMarton requested a review from a team as a code owner October 19, 2023 15:43
@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #382 (e12ce59) into main (caa3565) will decrease coverage by 1.80%.
The diff coverage is 4.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #382      +/-   ##
==========================================
- Coverage   76.86%   75.07%   -1.80%     
==========================================
  Files         173      177       +4     
  Lines        5564     5738     +174     
  Branches      233      233              
==========================================
+ Hits         4277     4308      +31     
- Misses       1286     1429     +143     
  Partials        1        1              
Files Coverage Δ
...ng/dotnet/src/Client/Client/MessageRouterClient.cs 81.75% <100.00%> (+0.08%) ⬆️
...ng/dotnet/src/Server/Server/MessageRouterServer.cs 86.19% <ø> (ø)
...ModuleLoader.Abstractions/ModuleLoaderConstants.cs 100.00% <100.00%> (ø)
...UI.ModuleLoader.Abstractions/WebManifestDetails.cs 100.00% <100.00%> (ø)
....ModuleLoader.Abstractions/WebStartupProperties.cs 100.00% <100.00%> (ø)
...DependencyInjection/ServiceCollectionExtensions.cs 100.00% <ø> (ø)
...mposeUI.ModuleLoader/Runners/NativeModuleRunner.cs 33.33% <ø> (ø)
....ComposeUI.ModuleLoader/Runners/WebModuleRunner.cs 83.33% <100.00%> (ø)
src/shell/dotnet/Shell/Fdc3/Fdc3Options.cs 0.00% <ø> (ø)
src/shell/dotnet/Shell/WebWindow.xaml 0.00% <ø> (ø)
... and 12 more

... and 2 files with indirect coverage changes

@BalassaMarton BalassaMarton merged commit ed72e7d into morganstanley:main Oct 25, 2023
2 of 4 checks passed
@BalassaMarton BalassaMarton deleted the shell-module-loader branch January 8, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants