Fix existing standalone web examples #420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ztanczos
commented
Feb 1, 2024
•
ztanczos
commented
- Add js-grid example to module catalog
- Remove redundant AppNotFoundException since that's available from MorganStanley.Fdc3.AppDirectory
- When the shell is started with the --url argument then create a ModuleManifest on-the-fly which is added to the ModuleCatalog so that it can be started via the ModuleLoader
- Serialize the WebWindowOptions to JSON and add it to the StartupRequest
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #420 +/- ##
=======================================
Coverage 88.24% 88.24%
=======================================
Files 43 43
Lines 2347 2347
Branches 292 292
=======================================
Hits 2071 2071
Misses 272 272
Partials 4 4 |
BalassaMarton
previously approved these changes
Feb 1, 2024
kruplm
previously approved these changes
Feb 1, 2024
…ganStanley.Fdc3.AppDirectory
…uleManifest on-the-fly which is added to the ModuleCatalog so that it can be started via the ModuleLoader - Serialize the WebWindowOptions to JSON and add it to the StartupRequest
…into js-grid_module
ztanczos
changed the title
lilla28
reviewed
Feb 2, 2024
BalassaMarton
suggested changes
Feb 2, 2024
BalassaMarton
previously approved these changes
Feb 2, 2024
BalassaMarton
previously approved these changes
Feb 2, 2024
lilla28
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.