Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial PR for NX monorepo #465

Merged
merged 226 commits into from
Apr 10, 2024
Merged

Conversation

lilla28
Copy link
Contributor

@lilla28 lilla28 commented Feb 20, 2024

Changes:

  • Added nx/dotnet plugin to the monorepo so we can build/test/serve our applications/libraries
  • Removed Lerna from the monorepo
  • Added project.json files
  • Fixed build scripts: NX<-Lerna
  • Modified tests so they can start processes from the dist folder, as now this is the output folder even though if you are building from VS22

Known Issues:

  1. Sometimes the tests are getting stuck
  2. Sometimes the build is corrupted: (remove package.lock.json and node_modules from the root and run npm i again)
  3. Sometimes tests are randomly failing for example: "EXEC : error : EPERM: operation not permitted, rename ...", and sometimes not :) but if you run them individually they will pass.
    ---->UPDATED: Some sources suggests to clean npm cache, because it might be corrupted (they expreienced this kind of errors during npm i)
    (not specific to NX, but https://bobbyhadz.com/blog/npm-err-code-eperm-operation-not-permitted)
    It also could be file permissions problem, anti-virus problem, temporary directory permissions problem, old dependencies(it is using the latest NX version)

@lilla28 lilla28 marked this pull request as ready for review February 20, 2024 14:07
@lilla28 lilla28 requested a review from a team as a code owner February 20, 2024 14:07
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 96.58120% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.12%. Comparing base (f042344) to head (847dc1d).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           nx-monorepo     #465      +/-   ##
===============================================
+ Coverage        88.79%   90.12%   +1.33%     
===============================================
  Files               42       45       +3     
  Lines             2275     2359      +84     
  Branches           283      192      -91     
===============================================
+ Hits              2020     2126     +106     
+ Misses             251      233      -18     
+ Partials             4        0       -4     
Files Coverage Δ
...messaging-client/src/client/MessageRouterClient.ts 93.92% <100.00%> (+5.05%) ⬆️
...g-client/src/protocol/messages/AbstractResponse.ts 100.00% <100.00%> (ø)
...saging-client/src/protocol/messages/MessageType.ts 100.00% <100.00%> (ø)
...ing-client/src/protocol/messages/PublishMessage.ts 89.28% <100.00%> (+0.82%) ⬆️
...ng-client/src/protocol/messages/PublishResponse.ts 100.00% <100.00%> (ø)
...nt/src/protocol/messages/RegisterServiceRequest.ts 88.88% <100.00%> (ø)
...g-client/src/protocol/messages/SubscribeMessage.ts 88.00% <100.00%> (+1.04%) ⬆️
...-client/src/protocol/messages/SubscribeResponse.ts 100.00% <100.00%> (ø)
...client/src/protocol/messages/UnsubscribeMessage.ts 88.00% <100.00%> (+1.04%) ⬆️
...lient/src/protocol/messages/UnsubscribeResponse.ts 100.00% <100.00%> (ø)
... and 2 more

... and 2 files with indirect coverage changes

@lilla28 lilla28 changed the base branch from main to nx-monorepo February 27, 2024 12:56
- Fixed AppDirectory service registrations
- Fixed FDC3 debug config
@lilla28 lilla28 force-pushed the playground/nx2 branch 2 times, most recently from 9cc2f1e to bb45f1d Compare February 28, 2024 09:35
dependabot bot and others added 8 commits March 1, 2024 12:24
Bumps [rimraf](https://github.com/isaacs/rimraf) from 4.1.2 to 5.0.5.
- [Changelog](https://github.com/isaacs/rimraf/blob/main/CHANGELOG.md)
- [Commits](isaacs/rimraf@v4.1.2...v5.0.5)

---
updated-dependencies:
- dependency-name: rimraf
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [karma](https://github.com/karma-runner/karma) from 6.4.2 to 6.4.3.
- [Release notes](https://github.com/karma-runner/karma/releases)
- [Changelog](https://github.com/karma-runner/karma/blob/master/CHANGELOG.md)
- [Commits](karma-runner/karma@v6.4.2...v6.4.3)

---
updated-dependencies:
- dependency-name: karma
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 6.0.8 to 6.0.9.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v6.0.8...v6.0.9)

---
updated-dependencies:
- dependency-name: System.Text.Json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 6.0.8 to 6.0.9.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v6.0.8...v6.0.9)

---
updated-dependencies:
- dependency-name: System.Text.Json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 6.0.8 to 6.0.9.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v6.0.8...v6.0.9)

---
updated-dependencies:
- dependency-name: System.Text.Json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 6.0.8 to 6.0.9.
- [Release notes](https://github.com/dotnet/runtime/releases)
- [Commits](dotnet/runtime@v6.0.8...v6.0.9)

---
updated-dependencies:
- dependency-name: System.Text.Json
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
bingenito and others added 10 commits April 1, 2024 11:47
…m_and_yarn/angular-7ca604bea5

chore(deps): bump the angular group with 11 updates
Bumps [highcharts](https://github.com/highcharts/highcharts-dist) from 11.3.0 to 11.4.0.
- [Commits](highcharts/highcharts-dist@v11.3.0...v11.4.0)

---
updated-dependencies:
- dependency-name: highcharts
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.3.3 to 5.4.3.
- [Release notes](https://github.com/Microsoft/TypeScript/releases)
- [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml)
- [Commits](microsoft/TypeScript@v5.3.3...v5.4.3)

---
updated-dependencies:
- dependency-name: typescript
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…m_and_yarn/typescript-5.4.3

chore(deps-dev): bump typescript from 5.3.3 to 5.4.3
@lilla28 lilla28 force-pushed the playground/nx2 branch 2 times, most recently from 5169cac to 7617423 Compare April 2, 2024 09:28
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.24.9 to 3.24.10.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@1b1aada...4355270)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
bingenito and others added 3 commits April 9, 2024 06:24
…thub_actions/github/codeql-action-3.24.10

chore(deps): bump github/codeql-action from 3.24.9 to 3.24.10
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 4.1.1 to 4.2.0.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@c16abc2...7afa10e)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…thub_actions/codecov/codecov-action-4.2.0

chore(deps): bump codecov/codecov-action from 4.1.1 to 4.2.0
@lilla28 lilla28 force-pushed the playground/nx2 branch 2 times, most recently from 305c6ad to 6dd51db Compare April 9, 2024 12:05
dependabot bot and others added 3 commits April 9, 2024 14:49
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 18.14.6 to 20.12.6.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
…X instead of Lerna, fixed packages-lock.json file
…on handling, added ProcessExtensions class for testing, fixed packages-lock
@kruplm kruplm merged commit b7f9c2a into morganstanley:nx-monorepo Apr 10, 2024
2 checks passed
@lilla28 lilla28 deleted the playground/nx2 branch September 5, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants