Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(messaging): Added Publish-, Subscribe- and UnsubscribeResponse types on both .NET and Typescript side, fixed DesktopAgent ModuleNotFound exception when removing module from the dictionary -running the chart and grid example. #471

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

lilla28
Copy link
Contributor

@lilla28 lilla28 commented Feb 27, 2024

  • Added Publish-, Subscribe- and UnsubscribeResponse types on both .NET and Typescript side
  • Fixed DesktopAgent ModuleNotFound exception when removing module from the dictionary -running the chart and grid example.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.12%. Comparing base (5d39722) to head (817cb86).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #471      +/-   ##
==========================================
+ Coverage   88.69%   90.12%   +1.42%     
==========================================
  Files          42       45       +3     
  Lines        2283     2359      +76     
  Branches      284      252      -32     
==========================================
+ Hits         2025     2126     +101     
+ Misses        254      230      -24     
+ Partials        4        3       -1     
Files Coverage Δ
...messaging-client/src/client/MessageRouterClient.ts 93.92% <100.00%> (+5.05%) ⬆️
...g-client/src/protocol/messages/AbstractResponse.ts 100.00% <100.00%> (ø)
...saging-client/src/protocol/messages/MessageType.ts 100.00% <100.00%> (ø)
...ing-client/src/protocol/messages/PublishMessage.ts 89.28% <100.00%> (+0.82%) ⬆️
...ng-client/src/protocol/messages/PublishResponse.ts 100.00% <100.00%> (ø)
...nt/src/protocol/messages/RegisterServiceRequest.ts 88.88% <100.00%> (ø)
...g-client/src/protocol/messages/SubscribeMessage.ts 88.00% <100.00%> (+1.04%) ⬆️
...-client/src/protocol/messages/SubscribeResponse.ts 100.00% <100.00%> (ø)
...client/src/protocol/messages/UnsubscribeMessage.ts 88.00% <100.00%> (+1.04%) ⬆️
...lient/src/protocol/messages/UnsubscribeResponse.ts 100.00% <100.00%> (ø)
... and 1 more

@lilla28 lilla28 marked this pull request as ready for review February 27, 2024 11:57
@lilla28 lilla28 requested a review from a team as a code owner February 27, 2024 11:57
@lilla28 lilla28 force-pushed the messaging/response-types branch 2 times, most recently from 3913e39 to d90214e Compare February 28, 2024 11:16
@lilla28 lilla28 force-pushed the messaging/response-types branch 3 times, most recently from dc345a8 to 16ee03a Compare March 4, 2024 09:28
ztanczos
ztanczos previously approved these changes Mar 4, 2024
@kruplm
Copy link
Contributor

kruplm commented Mar 7, 2024

Also when you fix the imports above, could you please include this as well?
https://github.com/lilla28/ComposeUI/blob/messaging/response-types/src/messaging/js/composeui-messaging-client/src/protocol/messages/RegisterServiceRequest.ts#L14

import { EndpointDescriptor } from "../../EndpointDescriptor";

I know it's not new code, but I spot this during the review as well.
Thank you

lilla28 added 2 commits March 8, 2024 10:33
…types on both .NET and Typescript side, fixed DesktopAgent ModuleNotFound exception when removing module from the dictionary -running the chart and grid example.
@lilla28 lilla28 force-pushed the messaging/response-types branch from fcfeb25 to 3d49992 Compare March 8, 2024 09:33
@lilla28 lilla28 merged commit b66be8d into morganstanley:main Mar 8, 2024
5 checks passed
kruplm pushed a commit that referenced this pull request Apr 10, 2024
…types on both .NET and Typescript side, fixed DesktopAgent ModuleNotFound exception when removing module from the dictionary -running the chart and grid example. (#471)

* chore(messaging): Added Publish-, Subscribe- and UnsubscribeResponse types on both .NET and Typescript side, fixed DesktopAgent ModuleNotFound exception when removing module from the dictionary -running the chart and grid example.

* chore(messaging): Removed try catch block, added exception OnStopRequest method

* fix(messaging) - Fixed imports in *.ts files
@lilla28 lilla28 deleted the messaging/response-types branch May 15, 2024 10:05
lilla28 added a commit to lilla28/ComposeUI that referenced this pull request Jul 12, 2024
…types on both .NET and Typescript side, fixed DesktopAgent ModuleNotFound exception when removing module from the dictionary -running the chart and grid example. (morganstanley#471)

* chore(messaging): Added Publish-, Subscribe- and UnsubscribeResponse types on both .NET and Typescript side, fixed DesktopAgent ModuleNotFound exception when removing module from the dictionary -running the chart and grid example.

* chore(messaging): Removed try catch block, added exception OnStopRequest method

* fix(messaging) - Fixed imports in *.ts files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants