-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(messaging): Added Publish-, Subscribe- and UnsubscribeResponse types on both .NET and Typescript side, fixed DesktopAgent ModuleNotFound exception when removing module from the dictionary -running the chart and grid example. #471
Conversation
lilla28
commented
Feb 27, 2024
- Added Publish-, Subscribe- and UnsubscribeResponse types on both .NET and Typescript side
- Fixed DesktopAgent ModuleNotFound exception when removing module from the dictionary -running the chart and grid example.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
==========================================
+ Coverage 88.69% 90.12% +1.42%
==========================================
Files 42 45 +3
Lines 2283 2359 +76
Branches 284 252 -32
==========================================
+ Hits 2025 2126 +101
+ Misses 254 230 -24
+ Partials 4 3 -1
|
3913e39
to
d90214e
Compare
src/messaging/js/composeui-messaging-client/src/client/MessageRouterClient.ts
Outdated
Show resolved
Hide resolved
src/messaging/js/composeui-messaging-client/src/client/MessageRouterClient.ts
Outdated
Show resolved
Hide resolved
dc345a8
to
16ee03a
Compare
src/messaging/js/composeui-messaging-client/src/protocol/messages/PublishMessage.ts
Outdated
Show resolved
Hide resolved
src/messaging/js/composeui-messaging-client/src/protocol/messages/SubscribeMessage.ts
Outdated
Show resolved
Hide resolved
src/messaging/js/composeui-messaging-client/src/protocol/messages/UnsubscribeMessage.ts
Outdated
Show resolved
Hide resolved
Also when you fix the imports above, could you please include this as well? import { EndpointDescriptor } from "../../EndpointDescriptor"; I know it's not new code, but I spot this during the review as well. |
…types on both .NET and Typescript side, fixed DesktopAgent ModuleNotFound exception when removing module from the dictionary -running the chart and grid example.
fcfeb25
to
3d49992
Compare
…types on both .NET and Typescript side, fixed DesktopAgent ModuleNotFound exception when removing module from the dictionary -running the chart and grid example. (#471) * chore(messaging): Added Publish-, Subscribe- and UnsubscribeResponse types on both .NET and Typescript side, fixed DesktopAgent ModuleNotFound exception when removing module from the dictionary -running the chart and grid example. * chore(messaging): Removed try catch block, added exception OnStopRequest method * fix(messaging) - Fixed imports in *.ts files
…types on both .NET and Typescript side, fixed DesktopAgent ModuleNotFound exception when removing module from the dictionary -running the chart and grid example. (morganstanley#471) * chore(messaging): Added Publish-, Subscribe- and UnsubscribeResponse types on both .NET and Typescript side, fixed DesktopAgent ModuleNotFound exception when removing module from the dictionary -running the chart and grid example. * chore(messaging): Removed try catch block, added exception OnStopRequest method * fix(messaging) - Fixed imports in *.ts files