Publishing Messaging nuget packages and some related CI streamlining #560 #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilla28
reviewed
Mar 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #561 +/- ##
===========================================
- Coverage 90.12% 74.38% -15.74%
===========================================
Files 45 238 +193
Lines 2359 7351 +4992
Branches 299 812 +513
===========================================
+ Hits 2126 5468 +3342
- Misses 232 1691 +1459
- Partials 1 192 +191 |
kruplm
requested changes
Mar 22, 2024
kruplm
approved these changes
Mar 25, 2024
kruplm
requested changes
Mar 25, 2024
There was a problem hiding this comment.
It doesn't seem to pick up the version upgrade for Node.js 20 from the repo variable despite updating the value:
Environment details
node: v18.18.2
npm: 9.8.1
yarn: 1.22.22
I recommend putting back the matrix for now as provenance won't happen for the NPM packages this way.
kruplm
approved these changes
Mar 26, 2024
Changed the CI workflow to use the dotnet build scripts for build and repo variables for framework versions Adjust dotnet-test script to use the Release build output from the dotnet-build script
Messaging libraries are packaged and placed under ./packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to publish the nuget packages I decided some streamlining on the dotnet build side is necessary. I separated the changes in 3 commits so they are easier to review and follow in the history.
I made the existing CI job to make use of the build scripts in the repository. This change is intended to have the ability to run the same build process locally.
I added variable usage for DOTNET_VERSION and NODE_VERSION so we don't have to adjust this across multiple workflow files. This needs to be set up on the main repo as well.
I adjusted the packaging scripts and projects so by default projects are not packaged, version is handled in a central location and packages are output in a central location. I enabled packaging for the Messaging libraries where necessary.
I added a deploy_to_nuget job to the release.yml workflow that pushes the packages. Note that packages are intentionally listed one by one in order to avoid accidentally pushing undersired packages to nuget.org
Further streamlining of the processes might be desirable, I didn't want to inflate this PR further.