Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module-loader) - Fixed ModuleLoader behavior with multiple modulecatalogs #606

Merged

Conversation

lilla28
Copy link
Contributor

@lilla28 lilla28 commented Apr 12, 2024

Changes:

  • picked up changes from branch and commits related to the ModuleLoader when it tries to register its ModuleCatalog 89ec2d9 && 57ad7da
  • fixed tests when it registers its modulecatalogs (mocking array of catalogs)

Please refer to the PR #569 that I accidentally closed.
I copied all the review comments/suggestions that the PR received and resolved them if they were marked as Resolved.
Also please be aware that the previous PR is not merged into any branch!

@lilla28 lilla28 requested a review from a team as a code owner April 12, 2024 20:51
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 76.59574% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 74.34%. Comparing base (71a5257) to head (fa881f3).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
- Coverage   74.36%   74.34%   -0.03%     
==========================================
  Files         238      241       +3     
  Lines        7358     7398      +40     
  Branches      872      818      -54     
==========================================
+ Hits         5472     5500      +28     
- Misses       1693     1706      +13     
+ Partials      193      192       -1     
Files Coverage Δ
...duleLoader.Abstractions/ModuleNotFoundException.cs 100.00% <100.00%> (ø)
...rganStanley.ComposeUI.ModuleLoader/ModuleLoader.cs 88.00% <100.00%> (-4.00%) ⬇️
...mposeUI.ModuleLoader/Runners/NativeModuleRunner.cs 48.48% <0.00%> (ø)
...y.ComposeUI.ModuleLoader/AggregateModuleCatalog.cs 86.66% <86.66%> (ø)
...ModuleLoader.Abstractions/ModuleLoaderException.cs 25.00% <25.00%> (ø)

... and 5 files with indirect coverage changes

@lilla28 lilla28 force-pushed the fix/module-loader-registration-vol2 branch from 3a62b0a to fa881f3 Compare April 16, 2024 07:25
@lilla28 lilla28 merged commit 7fec763 into morganstanley:main Apr 22, 2024
3 of 5 checks passed
@lilla28 lilla28 deleted the fix/module-loader-registration-vol2 branch May 15, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants