Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fdc3) - Refactored DesktopAgent queries to find the appropriate intents via raiseIntent, findIntent, findIntentsByContext call. Removed unnecessary codes, tests, code cleanup #611

Merged
merged 1 commit into from
May 3, 2024

Conversation

lilla28
Copy link
Contributor

@lilla28 lilla28 commented Apr 19, 2024

Changes:

  • refactored the intent queries (within backend's RaiseIntent, FindIntent, FindIntentsByContext handlers)
  • removed unnecessary code snippets and tests based on: 57ad7da
  • fixed typos within classes, descriptions, test utils (sample appdirectory)
  • removed unnecessary property from RaiseIntentRequest classes.
    image

@lilla28 lilla28 requested a review from a team as a code owner April 19, 2024 15:46
@lilla28 lilla28 force-pushed the fix/fdc3-findIntent branch from 2e1d2c9 to ae29277 Compare April 22, 2024 13:38
@lilla28 lilla28 force-pushed the fix/fdc3-findIntent branch from 7cfaead to eda9e38 Compare April 23, 2024 10:20
Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 79.25311% with 50 lines in your changes are missing coverage. Please review.

Project coverage is 74.07%. Comparing base (43ac1b4) to head (eadcf64).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
- Coverage   74.34%   74.07%   -0.28%     
==========================================
  Files         241      241              
  Lines        7398     7482      +84     
  Branches      771      829      +58     
==========================================
+ Hits         5500     5542      +42     
- Misses       1706     1745      +39     
- Partials      192      195       +3     
Files Coverage Δ
...nt/src/DesktopAgent/Contracts/FindIntentRequest.cs 100.00% <ø> (ø)
...ktopAgent/Contracts/FindIntentsByContextRequest.cs 100.00% <ø> (ø)
...t/src/DesktopAgent/Contracts/RaiseIntentRequest.cs 100.00% <ø> (ø)
...e/Internal/Fdc3DesktopAgentMessageRouterService.cs 94.84% <100.00%> (+1.91%) ⬆️
...ucture/Internal/RaiseIntentResolutionInvocation.cs 100.00% <100.00%> (ø)
.../infrastructure/messages/Fdc3RaiseIntentRequest.ts 100.00% <100.00%> (ø)
...opAgent/src/DesktopAgent/Exceptions/ThrowHelper.cs 25.00% <0.00%> (+8.33%) ⬆️
...rastructure/Internal/RaisedIntentRequestHandler.cs 80.00% <63.63%> (-2.23%) ⬇️
.../DesktopAgent/src/DesktopAgent/Fdc3DesktopAgent.cs 78.64% <78.57%> (-6.43%) ⬇️

... and 1 file with indirect coverage changes

@lilla28 lilla28 force-pushed the fix/fdc3-findIntent branch from eda9e38 to 6d1b309 Compare April 25, 2024 09:47
@lilla28 lilla28 force-pushed the fix/fdc3-findIntent branch 2 times, most recently from f7ba7f2 to a54a8ee Compare May 2, 2024 07:32
…ntents via raiseIntent, findIntent, findIntentsByContext call. Removed unnecessary codes, tests, code cleanup
@lilla28 lilla28 force-pushed the fix/fdc3-findIntent branch from a54a8ee to eadcf64 Compare May 3, 2024 10:11
@lilla28 lilla28 merged commit efe1b02 into morganstanley:main May 3, 2024
3 of 5 checks passed
@lilla28 lilla28 deleted the fix/fdc3-findIntent branch May 15, 2024 10:07
@lilla28 lilla28 restored the fix/fdc3-findIntent branch May 15, 2024 10:07
@lilla28 lilla28 deleted the fix/fdc3-findIntent branch May 21, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants