-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(icon-handling) - Disposing icon after ImageSource is created from its handle #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #617 +/- ##
==========================================
+ Coverage 74.05% 74.10% +0.04%
==========================================
Files 241 242 +1
Lines 7482 7495 +13
Branches 782 890 +108
==========================================
+ Hits 5541 5554 +13
+ Misses 1745 1741 -4
- Partials 196 200 +4
|
lilla28
force-pushed
the
icon-handling
branch
2 times, most recently
from
May 2, 2024 07:36
a9de499
to
fdf90c8
Compare
ztanczos
reviewed
May 2, 2024
lilla28
force-pushed
the
icon-handling
branch
2 times, most recently
from
May 3, 2024 12:21
35332f0
to
78df126
Compare
…he shared/tests/TestUtils folder, added to the Shared.sln's tests solution folder, corrected refernces
…heck if the icon handle is properly diposed
ztanczos
approved these changes
May 6, 2024
ZKRobi
approved these changes
May 7, 2024
fhubi
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: