Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(icon-handling) - Disposing icon after ImageSource is created from its handle #617

Merged
merged 4 commits into from
May 7, 2024

Conversation

lilla28
Copy link
Contributor

@lilla28 lilla28 commented Apr 30, 2024

Changes:

  • Added IconUtilites and NativeMethods static classes to convert and dispose Icon appropriately.
  • Whitespace changes, added headers
  • Moved MorganStanley.ComposeUI.Testing package under shared/tests/TestUtils

@lilla28 lilla28 requested a review from a team as a code owner April 30, 2024 15:55
@lilla28 lilla28 marked this pull request as draft April 30, 2024 15:58
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 74.10%. Comparing base (73c48c4) to head (8dd46ec).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
+ Coverage   74.05%   74.10%   +0.04%     
==========================================
  Files         241      242       +1     
  Lines        7482     7495      +13     
  Branches      782      890     +108     
==========================================
+ Hits         5541     5554      +13     
+ Misses       1745     1741       -4     
- Partials      196      200       +4     
Files Coverage Δ
.../MorganStanley.ComposeUI.Testing/TaskExtensions.cs 88.88% <ø> (ø)
src/shell/dotnet/Shell/Utilities/IconUtilities.cs 100.00% <100.00%> (ø)
src/shell/dotnet/Shell/MainWindow.xaml 0.00% <0.00%> (ø)
src/shell/dotnet/Shell/Utilities/DiagnosticInfo.cs 0.00% <0.00%> (ø)
src/shell/dotnet/Shell/App.xaml.cs 0.00% <0.00%> (ø)
src/shell/dotnet/Shell/MainWindow.xaml.cs 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@lilla28 lilla28 marked this pull request as ready for review May 2, 2024 07:29
@lilla28 lilla28 force-pushed the icon-handling branch 2 times, most recently from a9de499 to fdf90c8 Compare May 2, 2024 07:36
@lilla28 lilla28 force-pushed the icon-handling branch 2 times, most recently from 35332f0 to 78df126 Compare May 3, 2024 12:21
lilla28 and others added 3 commits May 3, 2024 17:23
…he shared/tests/TestUtils folder, added to the Shared.sln's tests solution folder, corrected refernces
@lilla28 lilla28 merged commit 47ad140 into morganstanley:main May 7, 2024
4 of 5 checks passed
@lilla28 lilla28 deleted the icon-handling branch May 21, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants