-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(messaging-documentation) - Add GH page for Message Router #638
chore(messaging-documentation) - Add GH page for Message Router #638
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #638 +/- ##
==========================================
- Coverage 74.11% 74.08% -0.03%
==========================================
Files 242 242
Lines 7495 7495
Branches 843 842 -1
==========================================
- Hits 5555 5553 -2
Misses 1742 1742
- Partials 198 200 +2 |
@mimiflynn , this would our first version specific documentation page. Can you please confirm we are doing the right thing? |
FYI I'm checking a local build with the changes at the moment. |
@psmulovics @lilla28 This is looking good to me based on the local build: @mimiflynn feel free to verify as well :) |
Message Router is an open-source out-of-the-box library that is fast and reliable. It supports JSON and it also uses WebSockets and has a Javascript library, so Web-based applications can be integrated. | ||
So basically it is real-time solution that can be easily setup for Pub-Sub messaging. | ||
|
||
More details can be found under the [ADR-012](https://github.com/morganstanley/ComposeUI/blob/main/architecture/adr-012-message-router.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any interest in having a section of the documentation site for these ADRs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mimiflynn , definitely. Where would you suggest putting them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it makes sense to keep in the docs section or do you think a separate ADR space would be better?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm far from being a designer :) but I'd put it under docs.
Changes: