Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(messaging-documentation) - Fix Javascript Gatsby highlights #640

Merged

Conversation

lilla28
Copy link
Contributor

@lilla28 lilla28 commented May 7, 2024

Changes:

  • Fixed gatsby highlights for Javascript codes as well

@lilla28 lilla28 requested a review from a team as a code owner May 7, 2024 17:12
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.10%. Comparing base (085b86f) to head (3ef7123).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #640   +/-   ##
=======================================
  Coverage   74.10%   74.10%           
=======================================
  Files         242      242           
  Lines        7495     7495           
  Branches      830      890   +60     
=======================================
  Hits         5554     5554           
+ Misses       1744     1741    -3     
- Partials      197      200    +3     

see 3 files with indirect coverage changes

@kruplm
Copy link
Contributor

kruplm commented May 8, 2024

The markup is not case-sensitive, but let's merge it for consistency with "csharp" being lower-case :)

@lilla28 lilla28 merged commit 7827e11 into morganstanley:main May 8, 2024
5 checks passed
@lilla28 lilla28 deleted the fix/message-router-doc-highlights branch May 15, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants