Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Grpc web service initial #679

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

agyen
Copy link
Contributor

@agyen agyen commented Jun 3, 2024

No description provided.

@agyen agyen requested a review from a team as a code owner June 3, 2024 10:19
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 69.26%. Comparing base (a16fbbc) to head (6d01c6a).
Report is 1 commits behind head on main.

Files Patch % Lines
...seUI.ProcessExplorer.Core/ProcessInfoAggregator.cs 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #679      +/-   ##
==========================================
- Coverage   72.00%   69.26%   -2.74%     
==========================================
  Files         260      250      -10     
  Lines        7833     7608     -225     
  Branches      933      912      -21     
==========================================
- Hits         5640     5270     -370     
- Misses       1991     2149     +158     
+ Partials      202      189      -13     
Files Coverage Δ
...xplorer.Core/Factories/ProcessAggregatorFactory.cs 0.00% <ø> (-100.00%) ⬇️
...seUI.ProcessExplorer.Core/ProcessInfoAggregator.cs 46.30% <50.00%> (-7.07%) ⬇️

... and 23 files with indirect coverage changes

@psmulovics
Copy link
Member

Can you please add the Grpc and protobuf version updates into this PR? #654 , #655 , #656 , #658

@bingenito bingenito requested a review from a team June 14, 2024 17:02
@agyen agyen force-pushed the grpc-web-server branch from 1db5c31 to 3ac70e3 Compare June 25, 2024 09:44
@agyen agyen force-pushed the grpc-web-server branch from 3a9db1a to 6ef141a Compare July 4, 2024 12:07
@agyen agyen force-pushed the grpc-web-server branch from 0d49ca4 to 2ca57fd Compare July 26, 2024 08:05
@kruplm
Copy link
Contributor

kruplm commented Jul 31, 2024

@agyen could you please update this branch so it contains the changes from the main one?

@agyen agyen force-pushed the grpc-web-server branch 4 times, most recently from 5154055 to c5076f7 Compare August 2, 2024 11:03
@agyen agyen force-pushed the grpc-web-server branch from ab1fb6e to 6d01c6a Compare August 2, 2024 13:59
@ZKRobi ZKRobi self-requested a review August 2, 2024 14:00
@kruplm kruplm merged commit 324b85c into morganstanley:main Aug 6, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants