-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Grpc web service initial #679
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #679 +/- ##
==========================================
- Coverage 72.00% 69.26% -2.74%
==========================================
Files 260 250 -10
Lines 7833 7608 -225
Branches 933 912 -21
==========================================
- Hits 5640 5270 -370
- Misses 1991 2149 +158
+ Partials 202 189 -13
|
bingenito
reviewed
Jun 14, 2024
...s/process-explorer/dotnet/src/gRPC-Web-Service/DependencyInjection/ProcessExplorerBuilder.cs
Outdated
Show resolved
Hide resolved
ZKRobi
requested changes
Jul 22, 2024
...net/src/MorganStanley.ComposeUI.ProcessExplorer.Abstractions/Processes/ProcessInfoMonitor.cs
Outdated
Show resolved
Hide resolved
...net/src/MorganStanley.ComposeUI.ProcessExplorer.Abstractions/Processes/ProcessInfoMonitor.cs
Outdated
Show resolved
Hide resolved
...t/src/MorganStanley.ComposeUI.ProcessExplorer.GrpcWebServer/Extensions/ProtoConvertHelper.cs
Outdated
Show resolved
Hide resolved
...seUI.ProcessExplorer.GrpcWebServer/MorganStanley.ComposeUI.ProcessExplorer.GrpcWebServer.sln
Outdated
Show resolved
Hide resolved
...poseUI.ProcessExplorer.GrpcWebServer/Server/Abstractions/ProcessExplorerBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
...plorer/dotnet/src/MorganStanley.ComposeUI.ProcessExplorer.GrpcWebServer/gRPC-Web-Service.sln
Outdated
Show resolved
Hide resolved
.../dotnet/test/MorganStanley.ComposeUI.ProcessExplorer.IntegrationTests/ServerEndToEndTests.cs
Outdated
Show resolved
Hide resolved
@agyen could you please update this branch so it contains the changes from the main one? |
agyen
force-pushed
the
grpc-web-server
branch
4 times, most recently
from
August 2, 2024 11:03
5154055
to
c5076f7
Compare
ZKRobi
approved these changes
Aug 2, 2024
lilla28
approved these changes
Aug 5, 2024
kruplm
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.