Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compose UI 24 code skeleton2 #71

Merged
merged 5 commits into from
Jul 28, 2022

Conversation

nick-polyak-ms
Copy link
Contributor

Another pull request based on #47

@nick-polyak-ms nick-polyak-ms requested a review from a team July 26, 2022 13:35
nick-polyak-ms pushed a commit to nick-polyak-ms/ComposeUI that referenced this pull request Jul 26, 2022
@nick-polyak-ms nick-polyak-ms force-pushed the COMPOSEUI-24_CodeSkeleton2 branch from 2002fe9 to db840ad Compare July 26, 2022 17:08
@nick-polyak-ms nick-polyak-ms force-pushed the COMPOSEUI-24_CodeSkeleton2 branch from 41a4818 to 1269a9d Compare July 26, 2022 20:29
@BalassaMarton
Copy link
Contributor

.NET projects under src should be added to the main .sln file. I recommend a folder structure in the solution that mirrors the actual file system folders to avoid confusion (we can also add a command to please to enforce this)

@nick-polyak-ms nick-polyak-ms force-pushed the COMPOSEUI-24_CodeSkeleton2 branch from c1b1e7f to 08347f2 Compare July 27, 2022 21:23
@nick-polyak-ms nick-polyak-ms force-pushed the COMPOSEUI-24_CodeSkeleton2 branch from c9c3623 to 7d661d8 Compare July 27, 2022 21:35
@nick-polyak-ms
Copy link
Contributor Author

.NET projects under src should be added to the main .sln file. I recommend a folder structure in the solution that mirrors the actual file system folders to avoid confusion (we can also add a command to please to enforce this)

I made the project names to be in sync with the folder names.

Also following Peter's advice I shortened most of the paths is order to avoid 260 character problems during the automated builds in the future.

@BalassaMarton
Copy link
Contributor

I actually like the this convention where the MorganStanley.ComposeUI prefix is omitted from the project folder names, it makes it much more readable. I'll update please to handle this in commands like please change namespace and please move project

@ZKRobi ZKRobi merged commit 5422a19 into morganstanley:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants