Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ADR on Module Loader lifetime events #710

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

ztanczos
Copy link
Contributor

  • Add ADR document explaining the choice of IObservable<T> for Module Loader lifetime events

@ztanczos ztanczos requested a review from a team as a code owner July 11, 2024 06:21
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.01%. Comparing base (ad3c1e3) to head (b5d295d).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #710   +/-   ##
=======================================
  Coverage   72.01%   72.01%           
=======================================
  Files         260      260           
  Lines        7833     7833           
  Branches      933      933           
=======================================
  Hits         5641     5641           
- Misses       1990     1991    +1     
+ Partials      202      201    -1     

see 1 file with indirect coverage changes

@ztanczos ztanczos merged commit 8372a34 into morganstanley:main Jul 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants