Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump actions/upload-artifact from 4.3.5 to 4.3.6 in the artifact-actions group #737

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/continuous-integration.yml
Original file line number Diff line number Diff line change
@@ -74,13 +74,13 @@ jobs:
powershell ./build/dotnet-pack.ps1
- name: Upload Nuget Packages
uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
with:
name: packages
path: ${{ github.workspace }}/packages

- name: Upload Shell Binaries
uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
with:
name: shell-binaries
path: ${{ github.workspace }}/src/shell/dotnet/Shell/bin/Release/net6.0-windows/
2 changes: 1 addition & 1 deletion .github/workflows/scorecard.yml
Original file line number Diff line number Diff line change
@@ -59,7 +59,7 @@ jobs:
# Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF
# format to the repository Actions tab.
- name: "Upload artifact"
uses: actions/upload-artifact@89ef406dd8d7e03cfd12d9e0a4a378f454709029 # v4.3.5
uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
with:
name: SARIF file
path: results.sarif

Unchanged files with check annotations Beta

public class ModuleManifest
{
public string Name { get; set; }

Check warning on line 17 in prototypes/multi-module-prototype/src/module-loader/dotnet/ModuleLoader/Modules/ModuleManifest.cs

GitHub Actions / build (6.0.x, 20.x)

Non-nullable property 'Name' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
public string StartupType { get; set; }

Check warning on line 18 in prototypes/multi-module-prototype/src/module-loader/dotnet/ModuleLoader/Modules/ModuleManifest.cs

GitHub Actions / build (6.0.x, 20.x)

Non-nullable property 'StartupType' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
public string UIType { get; set; }

Check warning on line 19 in prototypes/multi-module-prototype/src/module-loader/dotnet/ModuleLoader/Modules/ModuleManifest.cs

GitHub Actions / build (6.0.x, 20.x)

Non-nullable property 'UIType' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.
public string? Path { get; set; }
public string? Url { get; set; }
public string[]? Arguments { get; set; }
private readonly string _path;
private readonly int _port;
public ComposeHostedWebApp(string path, int port)

Check warning on line 24 in prototypes/multi-module-prototype/src/module-loader/dotnet/ModuleLoader/Runners/ComposeHostedWebApp.cs

GitHub Actions / build (6.0.x, 20.x)

Non-nullable field '_process' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.
{
_path = path;
_port = port;
switch (manifest.StartupType)
{
case (StartupType.Executable):
runner = new ExecutableRunner(manifest.Path, manifest.Arguments);

Check warning on line 26 in prototypes/multi-module-prototype/src/module-loader/dotnet/ModuleLoader/ModuleHostFactory.cs

GitHub Actions / build (6.0.x, 20.x)

Possible null reference argument for parameter 'launchPath' in 'ExecutableRunner.ExecutableRunner(string launchPath, string[]? arguments)'.
break;
case (StartupType.DotNetCore):
runner = new DotNetCoreRunner(manifest.Path, manifest.Arguments);

Check warning on line 29 in prototypes/multi-module-prototype/src/module-loader/dotnet/ModuleLoader/ModuleHostFactory.cs

GitHub Actions / build (6.0.x, 20.x)

Possible null reference argument for parameter 'path' in 'DotNetCoreRunner.DotNetCoreRunner(string path, string[]? arguments)'.
break;
case (StartupType.SelfHostedWebApp):
runner = new ComposeHostedWebApp(manifest.Path, manifest.Port.Value);

Check warning on line 32 in prototypes/multi-module-prototype/src/module-loader/dotnet/ModuleLoader/ModuleHostFactory.cs

GitHub Actions / build (6.0.x, 20.x)

Nullable value type may be null.

Check warning on line 32 in prototypes/multi-module-prototype/src/module-loader/dotnet/ModuleLoader/ModuleHostFactory.cs

GitHub Actions / build (6.0.x, 20.x)

Possible null reference argument for parameter 'path' in 'ComposeHostedWebApp.ComposeHostedWebApp(string path, int port)'.
break;
case (StartupType.None):
runner = null;

Check warning on line 35 in prototypes/multi-module-prototype/src/module-loader/dotnet/ModuleLoader/ModuleHostFactory.cs

GitHub Actions / build (6.0.x, 20.x)

Converting null literal or possible null value to non-nullable type.
break;
default:
throw new NotSupportedException("Unsupported startup type");
switch (manifest.UIType)
{
case (UIType.Window):
return new WindowedModuleHost(manifest.Name, instanceId, runner as IWindowedModuleRunner);

Check warning on line 45 in prototypes/multi-module-prototype/src/module-loader/dotnet/ModuleLoader/ModuleHostFactory.cs

GitHub Actions / build (6.0.x, 20.x)

Possible null reference argument for parameter 'moduleRunner' in 'WindowedModuleHost.WindowedModuleHost(string name, Guid instanceId, IWindowedModuleRunner moduleRunner)'.
case (UIType.Web):
return new WebpageModuleHost(manifest.Name, instanceId, manifest.Url, runner);
case (UIType.None):