Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDC3 improvements #744

Conversation

lilla28
Copy link
Contributor

@lilla28 lilla28 commented Aug 22, 2024

Implemented:
getOrCreateChannel
getUserChannels
getInfo
findInstances
getAppMetadata

Added some implementation to track the joined userchannels properly via fdc3.joinUserChannels -> messagerouter.invoke calls, todos added for the restriction of joining based on the userchannel set.

Refactored raiseIntent, findIntent, findIntentsByContext based on the FDC3 Conformance tests -> added exception handling based on the tests, quering based on the intentmetadata's key instead of the Name property

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 82.92683% with 147 lines in your changes missing coverage. Please review.

Project coverage is 68.93%. Comparing base (a75e955) to head (f6d7c38).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
...Stanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs 71.70% 91 Missing and 25 partials ⚠️
...fdc3/src/infrastructure/ComposeUIIntentListener.ts 0.00% 7 Missing ⚠️
...e/Internal/Fdc3DesktopAgentMessageRouterService.cs 85.71% 4 Missing and 1 partial ⚠️
...opAgent/Converters/DisplayMetadataJsonConverter.cs 0.00% 3 Missing ⚠️
.../MorganStanley.ComposeUI.DesktopAgent/Fdc3Topic.cs 76.92% 2 Missing and 1 partial ⚠️
...dc3/js/composeui-fdc3/src/ComposeUIDesktopAgent.ts 92.10% 3 Missing ⚠️
.../src/infrastructure/MessageRouterChannelFactory.ts 97.14% 2 Missing ⚠️
...rastructure/messages/Fdc3GetUserChannelsRequest.ts 86.66% 2 Missing ⚠️
...rastructure/messages/Fdc3JoinUserChannelRequest.ts 86.66% 2 Missing ⚠️
...nley.ComposeUI.DesktopAgent/Channels/AppChannel.cs 50.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
+ Coverage   67.66%   68.93%   +1.27%     
==========================================
  Files         261      289      +28     
  Lines        7997     8612     +615     
  Branches      894     1012     +118     
==========================================
+ Hits         5411     5937     +526     
- Misses       2399     2462      +63     
- Partials      187      213      +26     
Files with missing lines Coverage Δ
...Stanley.ComposeUI.DesktopAgent/Channels/Channel.cs 90.14% <100.00%> (+0.43%) ⬆️
....DesktopAgent/Contracts/CreateAppChannelRequest.cs 100.00% <100.00%> (ø)
...DesktopAgent/Contracts/CreateAppChannelResponse.cs 100.00% <100.00%> (ø)
...eUI.DesktopAgent/Contracts/FindInstancesRequest.cs 100.00% <100.00%> (ø)
...UI.DesktopAgent/Contracts/FindInstancesResponse.cs 100.00% <100.00%> (ø)
...UI.DesktopAgent/Contracts/GetAppMetadataRequest.cs 100.00% <100.00%> (ø)
...I.DesktopAgent/Contracts/GetAppMetadataResponse.cs 100.00% <100.00%> (ø)
...ComposeUI.DesktopAgent/Contracts/GetInfoRequest.cs 100.00% <100.00%> (ø)
...omposeUI.DesktopAgent/Contracts/GetInfoResponse.cs 100.00% <100.00%> (ø)
...I.DesktopAgent/Contracts/GetUserChannelsRequest.cs 100.00% <100.00%> (ø)
... and 34 more

... and 9 files with indirect coverage changes

@lilla28 lilla28 force-pushed the feat/getOrCreateChannel-getUserChannels-getInfo branch from 1360f8f to 55a8b58 Compare August 29, 2024 12:41
@lilla28 lilla28 marked this pull request as ready for review August 29, 2024 12:54
@lilla28 lilla28 requested a review from a team as a code owner August 29, 2024 12:54
@lilla28 lilla28 force-pushed the feat/getOrCreateChannel-getUserChannels-getInfo branch 2 times, most recently from 9dcb71c to 67ec210 Compare September 2, 2024 07:43
ztanczos
ztanczos previously approved these changes Sep 2, 2024
Copy link
Contributor

@ZKRobi ZKRobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the follow-up commits into the appropriate original commits

@lilla28 lilla28 force-pushed the feat/getOrCreateChannel-getUserChannels-getInfo branch 5 times, most recently from 96c9a12 to 1a67434 Compare September 4, 2024 12:32
ztanczos
ztanczos previously approved these changes Sep 5, 2024
…arted instances in the tests, refactored channel tests
…els, added fdc3.joinUserChannel to track the channels on the backend

fix(getUserChannels) - Using implementation instead of interface to serialize, removed unrelated console.logs
fix(fdc3) - Removing Assembly.GetExecutingAssembly() call
…ased on their key instaed of using the Name property
…ion handling via the Conformance tests, refactored private functions, added console.log messages for further debbugging
…ixed example dialog, added MessageRouterDuplicatEndpointException, added descriptions, removed comments, and todos
@lilla28 lilla28 force-pushed the feat/getOrCreateChannel-getUserChannels-getInfo branch from 8bed7e2 to f6d7c38 Compare September 5, 2024 11:14
@lilla28 lilla28 merged commit de6689a into morganstanley:main Sep 5, 2024
4 of 5 checks passed
@lilla28 lilla28 deleted the feat/getOrCreateChannel-getUserChannels-getInfo branch September 5, 2024 14:57
@lilla28 lilla28 restored the feat/getOrCreateChannel-getUserChannels-getInfo branch September 5, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants