-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FDC3 improvements #744
Merged
lilla28
merged 7 commits into
morganstanley:main
from
lilla28:feat/getOrCreateChannel-getUserChannels-getInfo
Sep 5, 2024
Merged
FDC3 improvements #744
lilla28
merged 7 commits into
morganstanley:main
from
lilla28:feat/getOrCreateChannel-getUserChannels-getInfo
Sep 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilla28
force-pushed
the
feat/getOrCreateChannel-getUserChannels-getInfo
branch
from
August 29, 2024 12:41
1360f8f
to
55a8b58
Compare
lilla28
force-pushed
the
feat/getOrCreateChannel-getUserChannels-getInfo
branch
2 times, most recently
from
September 2, 2024 07:43
9dcb71c
to
67ec210
Compare
ztanczos
previously approved these changes
Sep 2, 2024
ZKRobi
reviewed
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the follow-up commits into the appropriate original commits
.../DesktopAgent/test/MorganStanley.ComposeUI.DesktopAgent.Tests/Channels/ChannelTestFixture.cs
Outdated
Show resolved
Hide resolved
...et/DesktopAgent/test/MorganStanley.ComposeUI.DesktopAgent.Tests/Channels/UserChannelTests.cs
Outdated
Show resolved
Hide resolved
src/fdc3/dotnet/DesktopAgent/test/MorganStanley.ComposeUI.DesktopAgent.Tests/EndToEndTests.cs
Outdated
Show resolved
Hide resolved
src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs
Outdated
Show resolved
Hide resolved
src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs
Outdated
Show resolved
Hide resolved
...t/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Infrastructure/Internal/Constants.cs
Outdated
Show resolved
Hide resolved
src/fdc3/js/composeui-fdc3/src/infrastructure/ComposeUIIntentListener.ts
Outdated
Show resolved
Hide resolved
lilla28
force-pushed
the
feat/getOrCreateChannel-getUserChannels-getInfo
branch
5 times, most recently
from
September 4, 2024 12:32
96c9a12
to
1a67434
Compare
ztanczos
previously approved these changes
Sep 5, 2024
…arted instances in the tests, refactored channel tests
…els, added fdc3.joinUserChannel to track the channels on the backend fix(getUserChannels) - Using implementation instead of interface to serialize, removed unrelated console.logs
fix(fdc3) - Removing Assembly.GetExecutingAssembly() call
…ased on their key instaed of using the Name property
…ion handling via the Conformance tests, refactored private functions, added console.log messages for further debbugging
…d fdc3.getAppMetadata
…ixed example dialog, added MessageRouterDuplicatEndpointException, added descriptions, removed comments, and todos
lilla28
force-pushed
the
feat/getOrCreateChannel-getUserChannels-getInfo
branch
from
September 5, 2024 11:14
8bed7e2
to
f6d7c38
Compare
ZKRobi
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented:
getOrCreateChannel
getUserChannels
getInfo
findInstances
getAppMetadata
Added some implementation to track the joined userchannels properly via fdc3.joinUserChannels -> messagerouter.invoke calls, todos added for the restriction of joining based on the userchannel set.
Refactored raiseIntent, findIntent, findIntentsByContext based on the FDC3 Conformance tests -> added exception handling based on the tests, quering based on the intentmetadata's key instead of the Name property