Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump ts-jest from 29.2.4 to 29.2.5 #762

Merged
merged 1 commit into from
Sep 1, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 23 additions & 11 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/fdc3/js/composeui-fdc3/package.json
Original file line number Diff line number Diff line change
@@ -40,7 +40,7 @@
"jsdom": "^25.0.0",
"rimraf": "6.0.1",
"rollup": "^4.12.1",
"ts-jest": "29.2.4",
"ts-jest": "29.2.5",
"ts-node": "10.9.2",
"tslib": "^2.4.0",
"typescript": "^5.3.3"
2 changes: 1 addition & 1 deletion src/shell/js/composeui-node-launcher/package.json
Original file line number Diff line number Diff line change
@@ -35,7 +35,7 @@
"@types/node": "^22.0.2",
"jest": "29.7.0",
"rimraf": "^6.0.1",
"ts-jest": "29.2.4",
"ts-jest": "29.2.5",
"ts-node": "10.9.2",
"tslib": "^2.4.0",
"typescript": "^5.3.3"

Unchanged files with check annotations Beta

public string? RemoteHostname { get; private set; }
public ConcurrentDictionary<string, string>? ConnectionInformation { get; init; }
public string Status { get; private set; }
protected readonly Subject<KeyValuePair<string, ConnectionStatus>> ConnectionStatusSubject = new();

Check warning on line 51 in prototypes/process-explorer/dotnet/src/MorganStanley.ComposeUI.ProcessExplorer.Abstractions/Entities/ConnectionInfo.cs

GitHub Actions / build (6.0.x, 20.x)

'ConnectionInfo.ConnectionStatusSubject': new protected member declared in sealed type
public IObservable<KeyValuePair<string, ConnectionStatus>> ConnectionStatusEvents => ConnectionStatusSubject;
private readonly object _connectionInformationLock = new();
{
foreach (var connectionInfo in connectionInformation)
{
ConnectionInformation.AddOrUpdate(connectionInfo.Key, connectionInfo.Value,

Check warning on line 83 in prototypes/process-explorer/dotnet/src/MorganStanley.ComposeUI.ProcessExplorer.Abstractions/Entities/ConnectionInfo.cs

GitHub Actions / build (6.0.x, 20.x)

Dereference of a possibly null reference.
(_, _) => connectionInfo.Value);
}
}
try
{
startTime = thread.StartTime.ToString();

Check warning on line 87 in prototypes/process-explorer/dotnet/src/MorganStanley.ComposeUI.ProcessExplorer.Abstractions/Extensions/ProtoConvertHelper.cs

GitHub Actions / build (6.0.x, 20.x)

This call site is reachable on all platforms. 'ProcessThread.StartTime' is only supported on: 'linux', 'windows'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1416)
}
catch (Exception) { }
var itemKey = item.Key.ToString();
if (itemKey == null || itemValue == null)
{
logger?.EnvironmentVariableParingErrorDebug(itemKey, itemValue);

Check warning on line 53 in prototypes/process-explorer/dotnet/src/MorganStanley.ComposeUI.ProcessExplorer.Client/InformationHandlerHelper.cs

GitHub Actions / build (6.0.x, 20.x)

Possible null reference argument for parameter 'key' in 'void SourceGeneratedLoggerExtensions.EnvironmentVariableParingErrorDebug(ILogger logger, string key, string value)'.

Check warning on line 53 in prototypes/process-explorer/dotnet/src/MorganStanley.ComposeUI.ProcessExplorer.Client/InformationHandlerHelper.cs

GitHub Actions / build (6.0.x, 20.x)

Possible null reference argument for parameter 'value' in 'void SourceGeneratedLoggerExtensions.EnvironmentVariableParingErrorDebug(ILogger logger, string key, string value)'.
continue;
}
{
if (_subsystemLauncherCommunicator == null && _subsystemLauncher == null) return Task.CompletedTask;
return _subsystemLauncherCommunicator == null

Check warning on line 119 in prototypes/process-explorer/dotnet/src/MorganStanley.ComposeUI.ProcessExplorer.Core/Subsystems/SubsystemController.cs

GitHub Actions / build (6.0.x, 20.x)

Possible null reference return.
? launcherTask
: communicatorTask;
}
await _handler.UpdateConnection(assemblyId, connectionInfo);
}
public async Task UpdateConnectionStatus(string assemblyId, string connectionId, string status)

Check warning on line 237 in prototypes/process-explorer/dotnet/src/MorganStanley.ComposeUI.ProcessExplorer.Core/ProcessInfoAggregator.cs

GitHub Actions / build (6.0.x, 20.x)

This async method lacks 'await' operators and will run synchronously. Consider using the 'await' operator to await non-blocking API calls, or 'await Task.Run(...)' to do CPU-bound work on a background thread.
{
var runtimeInfoToModify = GetRuntimeInformation(assemblyId);
if (runtimeInfoToModify == null) return;
try
{
if (!Enum.TryParse(typeof(ConnectionStatus), status, out var connectionStatus)) return;
runtimeInfoToModify.UpdateConnection(Guid.Parse(connectionId), (ConnectionStatus)connectionStatus);

Check warning on line 245 in prototypes/process-explorer/dotnet/src/MorganStanley.ComposeUI.ProcessExplorer.Core/ProcessInfoAggregator.cs

GitHub Actions / build (6.0.x, 20.x)

Unboxing a possibly null value.
UpdateProcessInfoCollectorData(assemblyId, runtimeInfoToModify);
}
catch (Exception exception)
var field = typeof(ProcessInfoAggregator).GetField("_subsystemStateChanges", BindingFlags.NonPublic | BindingFlags.Instance);
if (field == null) throw new ArgumentNullException(nameof(field));
var queue = (ConcurrentQueue<KeyValuePair<Guid, string>>)field.GetValue(processInfoAggregator);

Check warning on line 366 in prototypes/process-explorer/dotnet/test/MorganStanley.ComposeUI.ProcessExplorer.Core.Tests/ProcessInfoAggregator.Tests.cs

GitHub Actions / build (6.0.x, 20.x)

Converting null literal or possible null value to non-nullable type.
if (queue == null) throw new ArgumentNullException(nameof(queue));
var succeed = queue.TryDequeue(out var result);
{
public Guid LaunchRequestId { get; set; }
public Guid StopRequestId { get; set; }
public string LaunchRequestSubsystemName { get; set; }

Check warning on line 507 in prototypes/process-explorer/dotnet/test/MorganStanley.ComposeUI.ProcessExplorer.Core.Tests/Subsystems/SubsystemLauncher.Tests.cs

GitHub Actions / build (6.0.x, 20.x)

Non-nullable property 'LaunchRequestSubsystemName' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the property as nullable.
public string StopRequestSubsystemName { get; set; }
public IEnumerable<KeyValuePair<Guid, string>> LaunchRequestIds { get; set; } = Enumerable.Empty<KeyValuePair<Guid, string>>();
public IEnumerable<KeyValuePair<Guid, string>> StopRequestIds { get; set; } = Enumerable.Empty<KeyValuePair<Guid, string>>();