Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fdc3 fixes #778

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Fdc3 fixes #778

merged 4 commits into from
Sep 11, 2024

Conversation

lilla28
Copy link
Contributor

@lilla28 lilla28 commented Sep 5, 2024

Description:

  • Changed error type when the InstanceId not found
  • Removed unnecessary casting
  • Trigger the fdc3Ready event after joining the channel if the channel is defined
  • Added check for app channels
  • Removed redundant filtering on AppChannels
  • Removed unncessary property

@lilla28 lilla28 requested a review from a team as a code owner September 5, 2024 12:10
@lilla28 lilla28 force-pushed the fix/fdc3-joinChannel branch from ba0e957 to 49a2167 Compare September 5, 2024 12:51
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 81.60920% with 16 lines in your changes missing coverage. Please review.

Project coverage is 68.53%. Comparing base (77de2de) to head (4eb8ed7).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nt/Infrastructure/Internal/UserChannelSetReader.cs 71.05% 6 Missing and 5 partials ⚠️
...Stanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs 75.00% 2 Missing and 2 partials ⚠️
...tanley.ComposeUI.DesktopAgent/Fdc3StartupAction.cs 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
- Coverage   68.96%   68.53%   -0.43%     
==========================================
  Files         292      293       +1     
  Lines        8676     8667       -9     
  Branches      925     1004      +79     
==========================================
- Hits         5983     5940      -43     
- Misses       2476     2510      +34     
  Partials      217      217              
Files with missing lines Coverage Δ
...oseUI.DesktopAgent/Contracts/RaiseIntentRequest.cs 100.00% <ø> (ø)
...DependencyInjection/ServiceCollectionExtensions.cs 100.00% <100.00%> (ø)
...ey.ComposeUI.DesktopAgent/Fdc3StartupProperties.cs 100.00% <100.00%> (ø)
...dc3/js/composeui-fdc3/src/ComposeUIDesktopAgent.ts 89.71% <100.00%> (-0.92%) ⬇️
...3/src/infrastructure/MessageRouterIntentsClient.ts 93.93% <100.00%> (ø)
.../infrastructure/messages/Fdc3RaiseIntentRequest.ts 100.00% <ø> (ø)
...tanley.ComposeUI.DesktopAgent/Fdc3StartupAction.cs 88.63% <95.83%> (+2.52%) ⬆️
...Stanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs 77.18% <75.00%> (+0.47%) ⬆️
...nt/Infrastructure/Internal/UserChannelSetReader.cs 71.05% <71.05%> (ø)

... and 11 files with indirect coverage changes

@lilla28 lilla28 marked this pull request as draft September 6, 2024 10:15
@lilla28 lilla28 marked this pull request as ready for review September 6, 2024 11:05
@lilla28 lilla28 force-pushed the fix/fdc3-joinChannel branch from 22b0240 to 95669d3 Compare September 6, 2024 13:29
@lilla28 lilla28 force-pushed the fix/fdc3-joinChannel branch 2 times, most recently from 6f3a5d2 to 785968d Compare September 6, 2024 16:17
@lilla28 lilla28 force-pushed the fix/fdc3-joinChannel branch from 785968d to 3bb50e9 Compare September 10, 2024 10:12
ZKRobi
ZKRobi previously approved these changes Sep 10, 2024
@lilla28 lilla28 force-pushed the fix/fdc3-joinChannel branch from 5d6794e to 4eb8ed7 Compare September 10, 2024 13:27
@lilla28 lilla28 merged commit 9ca098c into morganstanley:main Sep 11, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants