-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fdc3 fixes #778
Merged
Merged
Fdc3 fixes #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztanczos
reviewed
Sep 5, 2024
src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3StartupAction.cs
Outdated
Show resolved
Hide resolved
ztanczos
reviewed
Sep 5, 2024
lilla28
force-pushed
the
fix/fdc3-joinChannel
branch
from
September 5, 2024 12:51
ba0e957
to
49a2167
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #778 +/- ##
==========================================
- Coverage 68.96% 68.53% -0.43%
==========================================
Files 292 293 +1
Lines 8676 8667 -9
Branches 925 1004 +79
==========================================
- Hits 5983 5940 -43
- Misses 2476 2510 +34
Partials 217 217
|
lilla28
force-pushed
the
fix/fdc3-joinChannel
branch
from
September 6, 2024 13:29
22b0240
to
95669d3
Compare
ztanczos
reviewed
Sep 6, 2024
...ent/src/MorganStanley.ComposeUI.DesktopAgent/Infrastructure/Internal/UserChannelSetReader.cs
Outdated
Show resolved
Hide resolved
ztanczos
reviewed
Sep 6, 2024
...ent/src/MorganStanley.ComposeUI.DesktopAgent/Infrastructure/Internal/UserChannelSetReader.cs
Outdated
Show resolved
Hide resolved
ztanczos
reviewed
Sep 6, 2024
src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3StartupAction.cs
Outdated
Show resolved
Hide resolved
lilla28
force-pushed
the
fix/fdc3-joinChannel
branch
2 times, most recently
from
September 6, 2024 16:17
6f3a5d2
to
785968d
Compare
… when we joined to the channel if the channel Id is defined
… created when calling the method, added exception
lilla28
force-pushed
the
fix/fdc3-joinChannel
branch
from
September 10, 2024 10:12
785968d
to
3bb50e9
Compare
ZKRobi
previously approved these changes
Sep 10, 2024
kruplm
requested changes
Sep 10, 2024
…e projects to act upon the fdc3Ready event
lilla28
force-pushed
the
fix/fdc3-joinChannel
branch
from
September 10, 2024 13:27
5d6794e
to
4eb8ed7
Compare
kruplm
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: