Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs with the current versions of node and dotnet #867

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

misrarah
Copy link

@misrarah misrarah commented Dec 7, 2024

Updated docs with the current versions of node 20 and dotnet sdk 8
added a global.json file to enforce the SDK

@misrarah misrarah requested a review from a team as a code owner December 7, 2024 23:08
@kruplm
Copy link
Contributor

kruplm commented Dec 9, 2024

Hi @misrarah, thank you for the contribution.

The documentation hasn't been updated to contain the current version of .NET, because we haven't upgraded this project to .NET 8 yet.
It's in our pipeline and something we definitely want to do before our next release.

Also, please note that next to your contribution you need to commit a DCO

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.69%. Comparing base (cf6ca78) to head (09e1ab4).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
+ Coverage   67.65%   67.69%   +0.03%     
==========================================
  Files         300      300              
  Lines        8982     8982              
  Branches      935     1031      +96     
==========================================
+ Hits         6077     6080       +3     
+ Misses       2689     2686       -3     
  Partials      216      216              

see 6 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants