Translations #161
Translations #161
Conversation
There was a problem hiding this comment.
This file replaces what used to be a dynamic page in the /pages/ directory. Ideally, all content will live in /content/ and all content management will live in /src/.
|
|
||
| function getTemplate(page) { | ||
| return page.frontmatter.exercise ? exerciseTemplate : pageTemplate; | ||
| const path = page.internal.contentFilePath; | ||
| const isExerciseIndex = path.includes('index') && path.includes('exercise'); |
There was a problem hiding this comment.
Creates a new page template for index.mdx files that live in /exercises/.
| @@ -46,10 +46,10 @@ | |||
| "serve": "gatsby serve", | |||
| "clean": "gatsby clean", | |||
| "test": "echo \"Write tests! -> https://gatsby.dev/unit-testing\" && exit 1", | |||
| "pub": "rm -rf ../docs && mv public ../docs", | |||
| "pubWindows": "rd /S \"../docs\" && move public \"../docs\"" | |||
| "pub": "rimraf ../docs && mv public ../docs" | |||
There was a problem hiding this comment.
rimraf for all the OS's.
| import SummaryCard from '../components/summary-card'; | ||
| import Translations from '../components/translations'; | ||
|
|
||
| export const SHORTCODES = { Hero, Link, SummaryCard, Translations }; |
There was a problem hiding this comment.
These are the React components that are available in .mdx files.
| Sorry, the url you're looking for appears to be missing. Check out the | ||
| sitemap below to find your expected page. | ||
| </p> | ||
| <SiteMap location={location} nodes={nodes} /> |
There was a problem hiding this comment.
With the url updates, I went ahead and enhanced the 404 page with a sitemap so a user could hopefully find what they were looking for.
There was a problem hiding this comment.
I liked the sadness
There was a problem hiding this comment.
Sadness is always available.
There was a problem hiding this comment.
Head component to be used with Gatsby Head API.
mimiflynn
requested review from
poojanagvekar,
kristen-holmes,
wheeler-c and
olivierbeau
There was a problem hiding this comment.
Seems good from a high level perspective.
@mimiflynn Do we have a QA version of the website where we can preview changes in a commit ?
If not, it might be a cool addition :)
|
@olivierbeau I was just telling @kristen-holmes that I wish we had PR previews to act as QA but we don't have the option at the moment. |
Addresses issue #140
This PR is so large because of the number of files moved into a new directory to support translations. We will need to further review and adjust the content to account for translations support living within the
/exercises/directory. Because the translations will not be a 1:1 for each curriculum, each language index will be honed to the existing content. I'd like to automate this page, but that will have to live in another PR.