Provide default implementation of showNotification for Electron (#165)

Simply delegate to Electron. This still requires a polyfill to be provided (example in app.js) for Windows 7
morganstanley · Jun 11, 2018 · 38b0d6a · 38b0d6a
1 parent 40a6f72
commit 38b0d6a
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/src/Electron/electron.ts b/src/Electron/electron.ts
@@ -371,7 +371,16 @@ export class ElectronContainer extends WebContainerBase {
     }
 
     public showNotification(title: string, options?: NotificationOptions) {
-        throw new TypeError("showNotification requires an implementation.");
+        const Notification = this.electron.Notification;
+        const notify = new Notification(Object.assign(options || {}, { title: title }));
+        if (options["onClick"]) {
+            notify.addListener("click", options["onClick"]);
+        }
+        if (options["notification"]) {
+            notify.once("show", () => notify.addListener("click", options["notification"]["onclick"]));
+        }
+
+        notify.show();
     }
 
     public addTrayIcon(details: TrayIconDetails, listener: () => void, menuItems?: MenuItem[]) {

diff --git a/tests/unit/Electron/electron.spec.ts b/tests/unit/Electron/electron.spec.ts
@@ -339,6 +339,13 @@ describe("ElectronContainer", () => {
             Menu: {
                 buildFromTemplate: (menuItems: any) => { }
             },
+            Notification: (options: any) => {
+                return {
+                    show: () => {},
+                    addListener: () => {},
+                    once: () => {}
+                }
+            },
             require: (type: string) => { return {} },
             getCurrentWindow: () => { return windows[0]; }
         };
@@ -441,8 +448,10 @@ describe("ElectronContainer", () => {
     });
 
     describe("notifications", () => {
-        it("showNotification throws not implemented", () => {
-            expect(() => container.showNotification("title", {})).toThrowError(TypeError);
+        it("showNotification delegates to electron notification", () => {
+            spyOn(electron, "Notification").and.callThrough();
+            container.showNotification("title", <any> { onClick: () => {}, notification: { } });
+            expect(electron.Notification).toHaveBeenCalledWith({ title: "title", onClick: jasmine.any(Function), notification: jasmine.any(Object) });
         });
 
         it("requestPermission granted", (done) => {