Skip to content

Commit

Permalink
Fix developer experience for local building (#244)
Browse files Browse the repository at this point in the history
  • Loading branch information
bingenito authored May 17, 2019
1 parent 82fc24d commit 71fbea4
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 43 deletions.
42 changes: 4 additions & 38 deletions .vscode/tasks.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,49 +4,15 @@
"tasks": [
{
"taskName": "build",
"command": "${workspaceRoot}/node_modules/.bin/gulp",
"showOutput": "always",
"echoCommand": true,
"isShellCommand": true,
"isBuildCommand": true,
"problemMatcher": [
"$tsc",
{
"owner": "tslint",
"pattern": {
"regexp": "^(.+):\\s+\\(.+\\)\\s(\\S+)\\[(\\d+)(.{2})(\\d+)\\]:\\s+(.+)$",
"severity": 0,
"file": 2,
"line": 3,
"column": 5,
"message": 6
},
"fileLocation": "absolute"
}
]
},
{
"taskName": "watch",
"command": "${workspaceRoot}/node_modules/.bin/gulp",
"args": [
"watch"
],
"showOutput": "never",
"echoCommand": true,
"isShellCommand": true,
"problemMatcher": [
"$tsc"
]
},
{
"taskName": "analysis",
"command": "${workspaceRoot}/node_modules/.bin/gulp",
"command": "${workspaceRoot}/node_modules/.bin/lerna",
"args": [
"tslint"
"run",
"build:lerna"
],
"showOutput": "always",
"echoCommand": true,
"isShellCommand": true,
"isBuildCommand": true,
"problemMatcher": [
"$tsc",
{
Expand Down
9 changes: 4 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -48,11 +48,10 @@ Build the project. This runs static analysis, unit tests and bundles the output
rollup.

```
$ npm run build
$ npm run build && npm test
```

For those using [Visual Studio Code](https://code.visualstudio.com/), tasks.json has a compile task
configured and can be invoked via ctrl+shift+b by default.
For those using [Visual Studio Code](https://code.visualstudio.com/), tasks.json has a build task.

Development
-----------
Expand All @@ -63,7 +62,7 @@ To run the examples or to manually test scenarios in each container, there is a
a local server with live reload. This can be run directly via gulp or through npm.

```
$ npm run server
$ npm start
```

This is configured to listen at [http://localhost:8000](http://localhost:8000) and will reload upon
Expand All @@ -76,7 +75,7 @@ codebase.
The tests can be run independent of the build.

```
$ npm run test
$ npm test
```

A task is provided for [Visual Studio Code](https://code.visualstudio.com/) users that can be launched
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"author": "Morgan Stanley",
"scripts": {
"bootstrap": "lerna bootstrap",
"postinstall": "npm run bootstrap",
"tslint": "lerna run tslint",
"clean": "lerna run clean",
"build": "lerna run build:lerna",
Expand Down

0 comments on commit 71fbea4

Please sign in to comment.