-
Notifications
You must be signed in to change notification settings - Fork 40
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Switch over to eslint from tslint (#370)
* Adds eslint to replace tslint. * Uses recommended typescript rules. * Autofixable issues have been fixed, and other issues are ignored via comments. * Eslint runs separately to gulp, since I think we are moving away from gulp long term, and this is a cleaner solution even if we don't. * Husky added so that files are linted pre-commit. * Update travis to lint pre build.
- Loading branch information
Showing
49 changed files
with
2,573 additions
and
970 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
**/dist/* | ||
**/build/* | ||
**/gulpfile.js | ||
|
||
# Todo: remove and fix at some stage | ||
examples/* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
{ | ||
"parser": "@typescript-eslint/parser", | ||
"plugins": [ | ||
"@typescript-eslint" | ||
], | ||
"extends": [ | ||
"eslint:recommended", | ||
"plugin:@typescript-eslint/recommended" | ||
], | ||
"rules": { | ||
"@typescript-eslint/no-inferrable-types": ["error", { "ignoreProperties": true, "ignoreParameters": true}], | ||
"no-console": "error" | ||
}, | ||
"overrides": [ | ||
{ | ||
"files": ["**/*.spec.ts"], | ||
"rules": { | ||
"@typescript-eslint/no-empty-function": "off", | ||
"no-console": "warn" | ||
} | ||
} | ||
] | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,6 +10,7 @@ matrix: | |
|
||
script: | ||
- npm run bootstrap | ||
- npm run lint | ||
- npm run build | ||
- npm test | ||
- npm run docs | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,12 @@ | ||
{ | ||
"json.schemas": [ | ||
{ | ||
"fileMatch": [ "tslint.json" ], | ||
"url": "http://json.schemastore.org/tslint" | ||
}, | ||
{ | ||
"fileMatch": [ "app.json" ], | ||
"url": "http://json.schemastore.org/openfin" | ||
"url": "https://json.schemastore.org/openfin" | ||
}, | ||
{ | ||
"fileMatch": [ "tsconfig-staging.json" ], | ||
"url": "http://json.schemastore.org/tsconfig" | ||
"fileMatch": [ "tsconfig.staging.json" ], | ||
"url": "https://json.schemastore.org/tsconfig" | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.