Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relative url support in ElectronContainer.createWindow #140

Closed
bingenito opened this issue Mar 29, 2018 · 0 comments
Closed

Relative url support in ElectronContainer.createWindow #140

bingenito opened this issue Mar 29, 2018 · 0 comments
Assignees
@bingenito
Labels
area-Electron enhancement

Comments

@bingenito
Copy link
Member

Currently does not support relative urls which defeats some of the ability for the application to be easily container agnostic.
@bingenito bingenito self-assigned this Mar 29, 2018
bingenito referenced this issue in bingenito/desktopJS Apr 2, 2018
@bingenito
Relative url support for ElectronContainer.createWindow
af5eae0 
electron.ts:
- Ensure all url passed to new BrowserWindow are converted to absolute

Fixes #140
@bingenito bingenito mentioned this issue Apr 2, 2018
Merged
bingenito added a commit that referenced this issue Apr 4, 2018
@bingenito
Relative url support for ElectronContainer.createWindow (#143)
1fb98a6 
electron.ts:
- Ensure all url passed to new BrowserWindow are converted to absolute

Fixes #140
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bingenito bingenito

Labels
area-Electron enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bingenito