Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript 4.0.5 - inconsistent property/accessor in ContainerWindow vs. DefaultContainerWindow #385

Closed
Sly1024 opened this issue Nov 25, 2020 · 4 comments

Comments

@Sly1024
Copy link
Contributor

Sly1024 commented Nov 25, 2020

Compiling with Typescript 4.0.5 I received the following error messages:

 Error: node_modules/@morgan-stanley/desktopjs/dist/desktopjs.d.ts:677:21 - error TS2611: 'id' is defined as a property in class 'ContainerWindow', but is overridden here in 'DefaultContainerWindow' as an accessor.
    
    677                 get id(): string;
                            ~~
    node_modules/@morgan-stanley/desktopjs/dist/desktopjs.d.ts:678:21 - error TS2611: 'name' is defined as a property in class 'ContainerWindow', but is overridden here in 'DefaultContainerWindow' as an accessor.
    
    678                 get name(): string;
                            ~~~~
@Brookke
Copy link
Contributor

Brookke commented Nov 27, 2020

@Sly1024
Copy link
Contributor Author

Sly1024 commented Nov 30, 2020

Indeed, it fixes the issue. I tried it by manually editing the .d.ts file before the compilation.
I was going to do a PR and change these to property getters, but this should do the trick.
@Brookke When do you expect the merge to happen?

@Brookke
Copy link
Contributor

Brookke commented Nov 30, 2020

I was waiting on some changes for #383 to avoid creating any issues with merge conflicts etc and also need to find some time in my sprint to take a look at the remaining changes.

I shall instead spin that change off into its own PR so that the fix can get in sooner

@Brookke
Copy link
Contributor

Brookke commented Nov 30, 2020

PR open @Sly1024 #386

Sly1024 added a commit that referenced this issue Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants