-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript 4.0.5 - inconsistent property/accessor in ContainerWindow vs. DefaultContainerWindow #385
Comments
I believe https://github.com/Morgan-Stanley/desktopJS/blob/2ec0c82494f8b926e66a46d6d67c5b1555741d21/packages/desktopjs/src/window.ts#L87-L89 should fix this when it gets merged in #370 :) |
Indeed, it fixes the issue. I tried it by manually editing the .d.ts file before the compilation. |
I was waiting on some changes for #383 to avoid creating any issues with merge conflicts etc and also need to find some time in my sprint to take a look at the remaining changes. I shall instead spin that change off into its own PR so that the fix can get in sooner |
Compiling with Typescript 4.0.5 I received the following error messages:
The text was updated successfully, but these errors were encountered: