Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for linking windows to state changes of other windows #138

Merged
merged 2 commits into from
Mar 29, 2018

Conversation

bingenito
Copy link
Member

Minimize and restore all windows from the main window or within window groups.

electron.js, app.js:

  • Change default behavior of example to leverage the new window state tracking of main or group.

desktop.ts:

  • Expose through default export the new base GroupWindowManager and the WindowStateTracking enum

window.ts:

  • Add GroupWindowManager for tracking window state changes to drive state of other windows.
  • Refactor SnapAssistWindowManager core window tracking to new base GroupWindowManager.

…nimize and restore all windows from the main window or within window groups.

electron.js, app.js:
- Change default behavior of example to leverage the new window state tracking of main or group.

desktop.ts:
- Expose through default export the new base GroupWindowManager and the WindowStateTracking enum

window.ts:
- Add GroupWindowManager for tracking window state changes to drive state of other windows.
- Refactor SnapAssistWindowManager core window tracking to new base GroupWindowManager.
@bingenito bingenito requested a review from a team March 28, 2018 14:30
@codecov
Copy link

codecov bot commented Mar 28, 2018

Codecov Report

Merging #138 into master will increase coverage by 0.18%.
The diff coverage is 95.12%.

@@            Coverage Diff             @@
##           master     #138      +/-   ##
==========================================
+ Coverage   93.05%   93.24%   +0.18%     
==========================================
  Files          14       14              
  Lines        1138     1169      +31     
  Branches      192      203      +11     
==========================================
+ Hits         1059     1090      +31     
  Misses         79       79
Impacted Files Coverage Δ
src/desktop.ts 100% <100%> (ø) ⬆️
src/window.ts 89.15% <94.73%> (+1.71%) ⬆️

@bingenito bingenito merged commit 2cd8b98 into morganstanley:master Mar 29, 2018
@bingenito bingenito deleted the window-state-tracking branch March 29, 2018 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants