Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing of options in resolveContainer through to the container registrations condition and create callbacks #139

Merged
merged 1 commit into from
Mar 29, 2018

Conversation

bingenito
Copy link
Member

No description provided.

… registrations condition and create callbacks
@bingenito bingenito requested a review from a team March 28, 2018 17:53
@bingenito
Copy link
Member Author

This creates overloads on registerContainer

resolveContainer(force?: boolean): Container  /* This is the existing method */
resolveContainer(options?: any): Container
resolveContainer(force: boolean, options?: any): Container

@codecov
Copy link

codecov bot commented Mar 28, 2018

Codecov Report

Merging #139 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   93.02%   93.05%   +0.03%     
==========================================
  Files          14       14              
  Lines        1133     1138       +5     
  Branches      191      192       +1     
==========================================
+ Hits         1054     1059       +5     
  Misses         79       79
Impacted Files Coverage Δ
src/registry.ts 100% <100%> (ø) ⬆️

@bingenito bingenito merged commit e6b54cc into morganstanley:master Mar 29, 2018
@bingenito bingenito deleted the resolve-options branch March 29, 2018 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants