Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix registry tests #150

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Fix registry tests #150

merged 1 commit into from
Apr 20, 2018

Conversation

bingenito
Copy link
Member

  • Clear registry cache before each test instead of after
  • Mock internal container cached value when testing cached workflow to avoid race condition changing underlying value
  • Change TestContainer to have a condition that won't always resolve true unless matching option conditions are provided

@bingenito
Fix registry tests
644401c 
- Clear registry cache before each test instead of after
- Mock internal container cached value when testing cached workflow to avoid race condition changing underlying value
- Change TestContainer to have a condition that won't always resolve true unless matching option conditions are provided
@bingenito bingenito requested a review from a team April 20, 2018 13:40
@bingenito bingenito merged commit 631e19d into morganstanley:master Apr 20, 2018
@bingenito bingenito deleted the registry-tests branch May 11, 2018 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psmulovics psmulovics psmulovics approved these changes

Assignees
No one assigned
Labels
bug test-run-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bingenito @psmulovics