Allow override of default behavior of registring W3C notification api with options to resolveContainer #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bingenito
commented
May 8, 2018
bingenito
commented
- Add options support to factory create for ElectronContainer
- For OpenFin and Electron look for options.replaceNotificationApi on optional options to override default behavior
… with options to resolveContainer
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
==========================================
- Coverage 93.75% 93.64% -0.12%
==========================================
Files 15 15
Lines 1266 1274 +8
Branches 204 208 +4
==========================================
+ Hits 1187 1193 +6
- Misses 79 81 +2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.