Propagate Electron and OpenFin application level window created events instead of emitting our own #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s instead of emitting our own Fixes #155
Codecov Report
@@ Coverage Diff @@
## master #156 +/- ##
==========================================
+ Coverage 93.64% 93.94% +0.29%
==========================================
Files 15 15
Lines 1274 1271 -3
Branches 208 208
==========================================
+ Hits 1193 1194 +1
+ Misses 81 77 -4
|
psmulovics
approved these changes
May 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Electron we are no longer able to link a BrowserWindowProxy created via window.open to a BrowserWindow instance via guestID so instead use the app level browser-window-created event and webcontents.id to correlate to new windows. Since OpenFin also has application events, change to make consistent across both containers.
Fixes #155