Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gulp-replace to the latest version 🚀 #158

Merged
merged 2 commits into from
May 18, 2018

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented May 17, 2018

Version 1.0.0 of gulp-replace was just published.

Dependency gulp-replace
Current Version 0.6.1
Type devDependency

The version 1.0.0 is not covered by your current version range.

If you don’t accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of gulp-replace.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don’t have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Commits

The new version differs by 2 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 🌴

@greenkeeper greenkeeper bot requested a review from a team May 17, 2018 01:00
@codecov
Copy link

codecov bot commented May 18, 2018

Codecov Report

Merging #158 into master will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   93.87%   93.95%   +0.07%     
==========================================
  Files          15       15              
  Lines        1273     1273              
  Branches      210      210              
==========================================
+ Hits         1195     1196       +1     
+ Misses         78       77       -1
Impacted Files Coverage Δ
src/window.ts 89.67% <0%> (+0.46%) ⬆️

Copy link
Member

@bingenito bingenito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked all places in which replace is used within the build and lgtm.

@bingenito bingenito merged commit c44e0ea into master May 18, 2018
@bingenito bingenito deleted the greenkeeper/gulp-replace-1.0.0 branch May 18, 2018 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant