Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add simple facade for logging #164

Merged
merged 1 commit into from
May 29, 2018
Merged

Conversation

bingenito
Copy link
Member

Except for OpenFin, default implementation provided simply redirects to console..

@bingenito bingenito requested a review from a team May 29, 2018 17:12
@codecov
Copy link

codecov bot commented May 29, 2018

Codecov Report

Merging #164 into master will increase coverage by 0.1%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #164     +/-   ##
=========================================
+ Coverage   93.55%   93.66%   +0.1%     
=========================================
  Files          15       15             
  Lines        1273     1294     +21     
  Branches      210      215      +5     
=========================================
+ Hits         1191     1212     +21     
  Misses         82       82
Impacted Files Coverage Δ
src/OpenFin/openfin.ts 85.61% <100%> (+0.15%) ⬆️
src/container.ts 96.06% <100%> (+0.65%) ⬆️

@bingenito bingenito merged commit 40a6f72 into morganstanley:master May 29, 2018
@bingenito bingenito deleted the logging branch September 26, 2018 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants