Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor containers to use factory method for creating the message bus #178

Merged
merged 1 commit into from
Jul 23, 2018

Conversation

bingenito
Copy link
Member

Add MessageBusSubscription and MessageBusOptions to default exports for developer usage

@bingenito bingenito requested a review from a team July 23, 2018 15:17
@codecov
Copy link

codecov bot commented Jul 23, 2018

Codecov Report

Merging #178 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   93.82%   93.87%   +0.04%     
==========================================
  Files          15       15              
  Lines        1329     1338       +9     
  Branches      223      223              
==========================================
+ Hits         1247     1256       +9     
  Misses         82       82
Impacted Files Coverage Δ
src/Default/default.ts 97.54% <100%> (+0.02%) ⬆️
src/Electron/electron.ts 97.37% <100%> (+0.01%) ⬆️
src/OpenFin/openfin.ts 86.48% <100%> (+0.09%) ⬆️
src/desktop.ts 100% <100%> (ø) ⬆️

@bingenito bingenito merged commit dffbf31 into morganstanley:master Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants