Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for disabling snap dock for a window via snap option parameter #180

Merged
merged 1 commit into from
Jul 26, 2018

Conversation

bingenito
Copy link
Member

  • Add getOptions() to base ContainerWindow and implement in each concrete.
  • Support disable of individual windows from participating in snap docking with snap parameter in custom options to createWindow().
    container.createWindow(url, { snap: false });

@bingenito bingenito self-assigned this Jul 25, 2018
@bingenito bingenito requested a review from a team July 25, 2018 19:54
@bingenito bingenito changed the title Add support for disabling snap dock for a window via creation Add support for disabling snap dock for a window via snap option parameter Jul 25, 2018
@codecov
Copy link

codecov bot commented Jul 25, 2018

Codecov Report

Merging #180 into master will decrease coverage by 0.25%.
The diff coverage is 80.64%.

@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
- Coverage    93.8%   93.54%   -0.26%     
==========================================
  Files          15       15              
  Lines        1339     1364      +25     
  Branches      223      229       +6     
==========================================
+ Hits         1256     1276      +20     
- Misses         83       88       +5
Impacted Files Coverage Δ
src/Default/default.ts 97.58% <100%> (+0.03%) ⬆️
src/OpenFin/openfin.ts 86.66% <100%> (+0.18%) ⬆️
src/Electron/electron.ts 96.32% <70%> (-0.77%) ⬇️
src/window.ts 88.68% <80%> (-0.52%) ⬇️

@psmulovics
Copy link
Member

Strange diff on window.ts

@bingenito
Copy link
Member Author

@psmulovics re: window.ts, I refactored the entire contents of a callback into a separate method (onMoving()).

@bingenito
Copy link
Member Author

Disable whitespace diff and use split view instead of unified

@psmulovics
Copy link
Member

yeah, much better that way

@bingenito bingenito merged commit d08c95d into morganstanley:master Jul 26, 2018
@bingenito bingenito deleted the window-snap-disable branch September 26, 2018 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants