Add beforeunload as first class window event #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
=========================================
- Coverage 93.54% 93.35% -0.2%
=========================================
Files 15 15
Lines 1364 1384 +20
Branches 229 235 +6
=========================================
+ Hits 1276 1292 +16
- Misses 88 92 +4
|
bingenito
commented
Aug 15, 2018
| this.innerWindow.addEventListener(windowEventMap[eventName] || eventName, listener); | ||
| if (eventName === "beforeunload") { | ||
| this.innerWindow.addEventListener("close-requested", (e) => { | ||
| const args = new EventArgs(this, "beforeunload", e); |
There was a problem hiding this comment.
This callback is not covered in the test and is the resulting loss of coverage
bingenito
commented
Aug 16, 2018
|
|
||
| protected postProcessArgs(args: EventArgs) { | ||
| if (args && typeof args.returnValue !== "undefined") { | ||
| (<any>args.innerEvent).returnValue = args.returnValue; |
There was a problem hiding this comment.
desktopJS events wrap the internal container events for usage consistency. The returnValue on the djs event args needs to be propagated back to the inner event for the specific container.
satlus
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delegate beforeunload event on concrete ContainerWindow to either underlying container implementation or window object. This pattern will facilitate creating your own non window based beforeunload in custom ContainerWindow derivations.
Follows semantics of window beforeunload by leveraging returnValue on the event argument.