Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add facade for consistent access to underlying native JavaScript window #187

Merged
merged 1 commit into from
Sep 12, 2018

Conversation

bingenito
Copy link
Member

No description provided.

@bingenito bingenito requested a review from a team September 12, 2018 15:22
@codecov
Copy link

codecov bot commented Sep 12, 2018

Codecov Report

Merging #187 into master will increase coverage by 0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #187      +/-   ##
==========================================
+ Coverage   93.35%   93.39%   +0.03%     
==========================================
  Files          15       15              
  Lines        1384     1392       +8     
  Branches      235      236       +1     
==========================================
+ Hits         1292     1300       +8     
  Misses         92       92
Impacted Files Coverage Δ
src/window.ts 88.78% <100%> (+0.1%) ⬆️
src/Electron/electron.ts 96.4% <100%> (+0.01%) ⬆️
src/OpenFin/openfin.ts 85.71% <100%> (+0.09%) ⬆️
src/Default/default.ts 97.6% <100%> (+0.02%) ⬆️

@bingenito bingenito merged commit 5117608 into morganstanley:master Sep 12, 2018
@bingenito bingenito deleted the getNativeWindow branch September 26, 2018 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants