Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #224

Merged
merged 2 commits into from
Feb 15, 2019
Merged

Update dependencies #224

merged 2 commits into from
Feb 15, 2019

Conversation

bingenito
Copy link
Member

build.js:

  • Upgrade in rollup reduced unnecesary depth of bundle declaration so an update to the regex was required for our wrapping of the bundlne with an undefined check for desktopJS

Closes #211
Closes #212
Closes #222
Closes #223

- [email protected]
- [email protected]
- [email protected]
- [email protected]

build.js:
- Upgrade in rollup reduced unnecesary depth of bundle declaration so an update to the regex was required for our wrapping of the bundlne with an undefined check for desktopJS

Closes morganstanley#211
Closes morganstanley#212
Closes morganstanley#222
Closes morganstanley#223
@bingenito bingenito requested a review from a team February 15, 2019 19:57
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #224 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   93.44%   93.44%           
=======================================
  Files          16       16           
  Lines        1479     1479           
  Branches      249      249           
=======================================
  Hits         1382     1382           
  Misses         97       97

@bingenito bingenito merged commit 1409c65 into morganstanley:master Feb 15, 2019
@bingenito bingenito deleted the dependencies branch March 30, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants