Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container.ready event #239

Merged
merged 2 commits into from
May 9, 2019
Merged

Conversation

bingenito
Copy link
Member

  • Default base implementation simply returns a resolved promise
  • OpenFin ready maps to fin.desktop.main()

Fixes #236

@bingenito
Copy link
Member Author

@ggeorgievx-Tick42 How does this look at a core level?

@ggeorgievx-Tick42
Copy link

@bingenito Looks good to me, Brian. Thanks for the fast update 👌🏻🎉

@bingenito bingenito marked this pull request as ready for review May 7, 2019 13:11
@bingenito bingenito requested a review from a team May 7, 2019 13:11
@codecov
Copy link

codecov bot commented May 7, 2019

Codecov Report

Merging #239 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #239      +/-   ##
=========================================
+ Coverage   93.38%   93.4%   +0.01%     
=========================================
  Files          16      16              
  Lines        1481    1485       +4     
  Branches      249     249              
=========================================
+ Hits         1383    1387       +4     
  Misses         98      98
Impacted Files Coverage Δ
packages/desktopjs/src/container.ts 93.93% <100%> (+0.09%) ⬆️
packages/desktopjs-openfin/src/openfin.ts 86.84% <100%> (+0.07%) ⬆️

@bingenito bingenito merged commit 82fc24d into morganstanley:master May 9, 2019
@bingenito bingenito deleted the ISSUE-236 branch March 30, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add container.ready event
4 participants