Add persist: false option to createWindow #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If createWindow options include persist: false, do not include the window in layout persistence. Fixes morganstanley#241
bingenito
commented
May 29, 2019
| expect(windows[0].innerWindow).toEqual(MockWindow.singleton); | ||
| done(); | ||
| }); | ||
| describe("window management", () => { |
There was a problem hiding this comment.
This entire describe block was incorrect under another describe so moved out to higher level
bingenito
commented
May 29, 2019
| done(); | ||
| }); | ||
| }); | ||
| it("buildLayout skips windows with persist false", (done) => { |
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
+ Coverage 93.53% 93.57% +0.03%
==========================================
Files 16 16
Lines 1485 1494 +9
Branches 249 253 +4
==========================================
+ Hits 1389 1398 +9
Misses 96 96
|
psmulovics
approved these changes
May 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If createWindow options include persist: false, do not include the window in layout persistence.
Fixes #241